Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sample name cleaning regex configurable #64

Closed
ewels opened this issue Feb 10, 2021 · 2 comments
Closed

Make sample name cleaning regex configurable #64

ewels opened this issue Feb 10, 2021 · 2 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@ewels
Copy link
Member

ewels commented Feb 10, 2021

A bunch of steps in the pipeline attempt to clean off common filename suffixes to give nicer sample names, eg:

prefix = reads.toString() - ~/(.R1)?(_R1)?(_trimmed)?(\.fq)?(\.fastq)?(\.gz)?$/

  1. (.R1)? should probably be (\.R1)? as the . alone is a wildcard matching any character
  2. This regex should be kept as a params variable to avoid repeating, and to make it configurable by the end user if it's having an undesirable effect.
@ewels ewels added bug Something isn't working enhancement New feature or request labels Feb 10, 2021
@apeltzer apeltzer added this to the 2.4.0 milestone Aug 8, 2024
@atrigila atrigila self-assigned this Sep 30, 2024
@atrigila
Copy link
Contributor

The code has undergone significant changes since this issue was raised, and this specific line no longer exists. Additionally, the regex configuration is now handled via MultiQC :)

@apeltzer
Copy link
Member

Issue from 2021 closed 👌🙏

nschcolnicov pushed a commit that referenced this issue Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

3 participants