Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automation to update example dockerfiles in the unit docs repo #1451

Open
avahahn opened this issue Oct 7, 2024 · 1 comment
Open

Add automation to update example dockerfiles in the unit docs repo #1451

avahahn opened this issue Oct 7, 2024 · 1 comment

Comments

@avahahn
Copy link
Contributor

avahahn commented Oct 7, 2024

See: example dockerfiles
See: related issue in unit-docs

We can automate opening a PR to the unit-docs repository to update all of these dockerfiles. Doing so would reduce the complexity of the release process in that we wouldn't have to worry about doing this ourselves. As it stands it appears that we have forgotten to do this since 1.31.1 and these dockerfiles are now super out of date.

As an example of how we could automate this: we could add a new github actions workflow that triggers on a new release tag, and programmatically opens a PR to the docs repository with the updated dockerfiles. In implementing this we would want to make sure that the source repository is not a fork of Unit and that the dockerfiles as they sit in this repository are ready to merge to the docs repository.

@callahad
Copy link
Collaborator

  • We should go ahead and manually update the files now.
  • We should update RELEASE-PROCESS.md in Add RELEASE-PROCESS.md #1435 to have a manual step to update these with every release.
  • We should remove that manual step when this automation issue is addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants