Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hydrograph does not work with seasonal gauges #15

Open
nickyrong opened this issue Jan 29, 2021 · 1 comment
Open

Hydrograph does not work with seasonal gauges #15

nickyrong opened this issue Jan 29, 2021 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@nickyrong
Copy link
Owner

The hydrograph tab will run into error when the gauge is seasonal:

Warning: Error in :: NA/NaN argument
168: %>%
167: renderPlot [/ShinyCFA/server.R#287]
165: func
125: drawPlot
111: reactive:plotObj
95: drawReactive
82: origRenderFunc
81: output$hydrograph
1: runApp

@nickyrong nickyrong self-assigned this Jan 29, 2021
@nickyrong nickyrong added the bug Something isn't working label Jan 29, 2021
@nickyrong
Copy link
Owner Author

The hydrologic regime plot is generated by a function from the FlowScreen package (there are some not yet implemented trend test functions commented out in the code also from FlowScreen package).

However, it does not looks like FlowScreen is being actively developed (last commit in 2019). It is therefore better to move away from FlowScreen and use similar functions from fasstr instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant