Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance problem #32

Open
AqlaSolutions opened this issue Mar 19, 2016 · 0 comments
Open

Performance problem #32

AqlaSolutions opened this issue Mar 19, 2016 · 0 comments
Assignees

Comments

@AqlaSolutions
Copy link

I want to use your Factory extension so I profiled your project and found several inefficient code places changing which could really improve performance:

1/ FuncProvider.Create should cache result of

functionFactory.GetMethodInfo(genericArguments.Length).MakeGenericMethod(genericArguments) 

with static ConcurrentDictionary or alternatives.

2/ FuncProvider.Create should use cached Reflection.Emit-ed method to do Invoke instead of plain reflection.

3/ FunctionFactory.GetMethodInfo should cache its results.

@scott-xu scott-xu self-assigned this Oct 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants