-
-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Size limits on repos? #133
Comments
Oh boi. Yeah, we should have a size limit. |
also related to #132 |
Maybe we can do a size limit per file also? |
I also thought about excluding large repositories from being included in nur-combined. |
for my repo i do a subdirectory-filter with |
That's perfectly fine, in the end you're absolutely right, that was a pretty bad idea :/ I have to admit that I currently don't use the NUR mechanism as I figured some time ago that simply using |
I suppose we would need a history rewrite to undo this. |
Looks like the build has been broken since #134. Is there a fix planned? |
I was wondering why nur-combined was so big, turns out there's a 30+ gif in someone's repo! 😆
Well, that'd do it. But perhaps the update checker should consider such binary assets similar to a failing evaluation? Problem is deciding how big is too big...
And sorry to name names but the repo is @Ma27's-- @Ma27 is there a good alternative approach/location for storing the demo.gif that doesn't bundle it with your expressions?
I don't think it's catastrophically bad, and mostly impacts anyone curious about that repo or using nur-combined. Questions above are more about ensuring there's not some multi-gigabyte beast in the future.
The text was updated successfully, but these errors were encountered: