Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Size limits on repos? #133

Open
dtzWill opened this issue May 10, 2019 · 9 comments
Open

Size limits on repos? #133

dtzWill opened this issue May 10, 2019 · 9 comments

Comments

@dtzWill
Copy link
Contributor

dtzWill commented May 10, 2019

I was wondering why nur-combined was so big, turns out there's a 30+ gif in someone's repo! 😆

Well, that'd do it. But perhaps the update checker should consider such binary assets similar to a failing evaluation? Problem is deciding how big is too big...

And sorry to name names but the repo is @Ma27's-- @Ma27 is there a good alternative approach/location for storing the demo.gif that doesn't bundle it with your expressions?

I don't think it's catastrophically bad, and mostly impacts anyone curious about that repo or using nur-combined. Questions above are more about ensuring there's not some multi-gigabyte beast in the future.

@Mic92
Copy link
Member

Mic92 commented May 11, 2019

Oh boi. Yeah, we should have a size limit.

@Mic92
Copy link
Member

Mic92 commented May 11, 2019

also related to #132

@Mic92
Copy link
Member

Mic92 commented May 11, 2019

Maybe we can do a size limit per file also?

@Mic92
Copy link
Member

Mic92 commented May 11, 2019

I also thought about excluding large repositories from being included in nur-combined.

@makefu
Copy link
Member

makefu commented May 11, 2019

for my repo i do a subdirectory-filter with git filter-branch to avoid exporting all my systems config,modules,libs and tests ( https://git.shackspace.de/krebs/stockholm/blob/master/.gitlab-ci.yml#L15 ).

@Ma27
Copy link
Member

Ma27 commented May 11, 2019

And sorry to name names but the repo is @Ma27's-- @Ma27 is there a good alternative approach/location for storing the demo.gif that doesn't bundle it with your expressions?

That's perfectly fine, in the end you're absolutely right, that was a pretty bad idea :/

I have to admit that I currently don't use the NUR mechanism as I figured some time ago that simply using nix.nixPath and import <nixexprs> { /* ... */ } suits better for my workflow. As it isn't the first time I got pinged due to some problem with my repository I guess that it's the best for everyone if I remove my repo from NUR for now.

@Mic92
Copy link
Member

Mic92 commented May 12, 2019

I suppose we would need a history rewrite to undo this.

@yurrriq
Copy link
Contributor

yurrriq commented May 15, 2019

Looks like the build has been broken since #134. Is there a fix planned?

@yurrriq
Copy link
Contributor

yurrriq commented May 23, 2019

milahu pushed a commit to milahu/NUR that referenced this issue Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants