Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additonal functions: Configure table name & #42

Open
strtob opened this issue Jan 24, 2018 · 7 comments
Open

Additonal functions: Configure table name & #42

strtob opened this issue Jan 24, 2018 · 7 comments

Comments

@strtob
Copy link

strtob commented Jan 24, 2018

Hi,

Really great job! Some function would be very helpful!

  1. Possibility to set the table name prefix like "tbl_user_"
  2. Button to generate thumbnail

Unfortunately, I'm just a beginner so I don't know how to contribute in the development and hope that this points will be develop in the plugin.

all the best
Toby

@noam148
Copy link
Owner

noam148 commented Jan 24, 2018

Hi,

I will need to check if that is possible. To generate a thumbnail I will not integrate in the module but there are possibilitys to do I by your own.

For a long time I haven't support the module. But I will start work on it again to fix some bug's and add new features.

I let you know Sunday!

@strtob
Copy link
Author

strtob commented Jan 24, 2018

This would be great, I'm looking forward to!

How can I extend and develop your tool by my own without getting overwritten with the next composer update or version update?

Have a good one

@xenogenesi
Copy link

xenogenesi commented Feb 1, 2018

  1. Possibility to set the table name prefix like "tbl_user_"

Actually should be enough to change everywhere the table is referenced from 'ImageManager' to '{{%ImageManager}}', I did so and seems to be working just fine, if a table prefix is set in db.php then it should be used.

How can I extend and develop your tool by my own without getting overwritten with the next composer update or version update?

@strtob you should create your own fork of this repository on github, then edit the composer.json of the project using it and add something like that:

"repositories": [
    // there could be already asset-packagist there...
    {
        "type": "vcs",
        "url": "https://github.com/strtob/yii2-image-manager"
    }
]

A composer update noam148/yii2-image-manager should replace the directory within vendor/ with the clone from your repository.

But be aware that if this repository get updated you'll have to merge it in order to get the fixes or new features (and eventually manually resolve conflicts if your changes are in the same spot).

I think the best would be: fork, try to apply changes in a way that can be useful to you and everybody else, commit and then create a pull request toward this repository.

@noam148, in the issues I've opened I forgot to thank you for sharing this addon, has been already very useful to me, thanks a lot, I'm not very confident with pull requests but I'll try soon to create some for the few issues I've fixed (apologies for my english).

@strtob
Copy link
Author

strtob commented Feb 3, 2018

Thanks xenogenesi!

Do you know an easy possiblity how I can add additional attribute to the images like a description or user defined and editable name?

I try to render the imagemanager in a view to have it as a tabX, but I have no clue how to do it :-/

@noam148
Copy link
Owner

noam148 commented Feb 3, 2018

Hi everyone, sorry for my late response and that the project is not active. I wil start develop the project again when i'm back from holiday. Then i will work a couple of hours per week on it. I will start with the oldest issues. So some patiance is needed.

And @strtob thanks for continue the project. If all the issue done I will take a look at your repository what i can use for this project! Thanks a lot!

@gugatxr
Copy link
Contributor

gugatxr commented Feb 18, 2018

Thank you @xenogenesi. Your comment help me a lot. For me, to update composer was necessery add a release or tag.

@noam148 I'm insterested in help with the repo. I just add a feature to get the url from the original image, without pass width and height.
Thank you for the package

@noam148
Copy link
Owner

noam148 commented Feb 18, 2018

Thanks for all the help! @gugatxr help and pull requests are always welcome! Today I started again to develop on the project, and wil fix the opened issues. This issue I will pickup the next time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants