Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shortfin test failures on Windows #295

Open
ScottTodd opened this issue Oct 17, 2024 · 0 comments
Open

Fix shortfin test failures on Windows #295

ScottTodd opened this issue Oct 17, 2024 · 0 comments

Comments

@ScottTodd
Copy link
Member

A few test cases are failing and were tagged to be skipped on Windows in #289 and #293.

  • In shortfin/tests/api/array_storage_test.py, test_fill_error (parameterized and unparameterized) crashed with Windows fatal exception: access violation
  • In shortfin/tests/host_cpu_system_test.py, test_create_host_cpu_system_topology_nodes_all crashed with Windows fatal exception: access violation
  • In shortfin/tests/host_cpu_system_test.py, test_create_host_cpu_system_env_vars failed with
    FAILED tests/host_cpu_system_test.py::test_create_host_cpu_system_env_vars - AssertionError: assert 1 == 2
     +  where 1 = len([Device(name='hostcpu:0:0@0', ordinal=0:0, node_affinity=0, capabilities=0x1)])
     +    where [Device(name='hostcpu:0:0@0', ordinal=0:0, node_affinity=0, capabilities=0x1)] = <_shortfin_default.lib.local.System object at 0x0000020CF2DD6770>.devices
    

The crashes aren't producing useful logs on CI or locally. Sample: https://github.com/nod-ai/SHARK-Platform/actions/runs/11376394068/job/31648798745#step:9:241 . Not sure what the current state of Python with native code debugging is. We might be missing something as part of the nanobind setup? I would expect a callstack from the thread with C++ symbols in it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant