-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(sharktank) Python3.12+ not supported for torch.compile #349
Comments
We should relax that to 3.10 to 3.13 and at least add unit test coverage for the older versions. We'll want to use the newer versions for real runs because it is faster. |
whereas we do not pin for the GPU
|
|
I'm assuming we are pinning torch to 2.3 due to previous issues with iree-turbine. That should be resolved now so I think we can bump torch without hopefully too much issue now. |
In the CI workflow iree-turbine's unit tests recently passed with torch==2.5.1 (see the logs here). Within a quick test, I bumped torch to 2.4.1 or 2.5.1 as part of #372 but this failed (see the logs here). |
When getting setup with shortfin I see several sharktank test failures due to the Python3.12 version shortfin requires.
To recreate following setup instructions on https://github.com/nod-ai/SHARK-Platform/tree/main?tab=readme-ov-file#development-getting-started with python3.12
Errors with
The text was updated successfully, but these errors were encountered: