Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polybius Square cipher: Issues in current implementation #9

Open
kobby-pentangeli opened this issue Sep 14, 2023 · 0 comments
Open
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers

Comments

@kobby-pentangeli
Copy link
Contributor

  1. Input Validation: The clean_input helper function only considers alphabets and spaces as valid inputs, discarding others. This means messages containing numbers or special characters can't be encrypted or decrypted correctly, which might be used as an attack vector to feed malicious inputs.

  2. Error Handling: The implementation uses Option to handle errors, returning None when encountering an error. A more detailed error handling is desired.

  3. Unicode Support: The implementation currently does not handle Unicode characters well, which might be exploited in various ways, including bypassing input validation or creating unexpected outputs.

@kobby-pentangeli kobby-pentangeli added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers labels Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant