RecyclerView click event getting blocked

[gbhaumikkumar14]

• Markwon version: 4.3.1

When i set any text using below code, parent recyclerview item view click is not working.

Markwon markwon = Markwon.builder(aViewHolder.mContext)
                    .usePlugin(StrikethroughPlugin.create())
                    .usePlugin(new AbstractMarkwonPlugin() {
                        @Override
                        public void configureParser(@NonNull Parser.Builder builder) {
                            builder.inlineParserFactory(inlineParserFactory);
                        }
                    })
                    .build();

final TextView lTextview = findViewById(R.id.textview);
markwon.setMarkdown(lTextview, aMessage);

final ConstraintLayout parent = findViewById(R.id.parent);
parent.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View view) {
                Toast.makeText(getApplicationContext(), "Clicked on TextView", Toast.LENGTH_SHORT).show();
            }
        });

Toast is not coming.
But when i set individual click listener on textview than it's working normal.

[noties]

Hello @gbhaumikkumar14 !

Markwon is not applying any touch/click listeners. How do you initialize click listener for the parent recyclerview item view?

[gbhaumikkumar14]

I have updated the comment you can check on any parent view if you set click listener and touch textview it's not working.

[gbhaumikkumar14]

Hello @gbhaumikkumar14 !

Markwon is not applying any touch/click listeners. How do you initialize click listener for the parent recyclerview item view?

I have done like this.

lViewHolder.itemView.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View view) {
                Toast.makeText(getApplicationContext(), "Clicked on TextView", Toast.LENGTH_SHORT).show();
            }
        });

[noties]

Can you confirm that it is Markwon issue by not using it? Instead apply your raw text on the TextView and see if it is be clickable?

[gbhaumikkumar14]

Can you confirm that it is Markwon issue by not using it? Instead apply your raw text on the TextView and see if it is be clickable?

Yes i confirmed, after applying markdown only that is happening. If i remove setMarkdown and simple use setText than it's working.

[noties]

Can you try calling:

textView.setMovementMethod(LinkMovementMethod.getInstance());

before applying markdown?

[gbhaumikkumar14]

Can you try calling:

textView.setMovementMethod(LinkMovementMethod.getInstance());

before applying markdown?

No Change in behavior. Still blocking click event.

[noties]

There is some weirdness around it. There are similar reports (this for example). And for me it doesn't work even if raw text is set (not markdown). I suggest you set your click listener on the TextView directly, especially if you are planning to have parts of that TextView clickable (links)

[gbhaumikkumar14]

Can you try without recyclerview ?
Just create one ConstraintLayout and put textview under ConstraintLayout.
Now set Click listener on ConstraintLayout and put Toast in it..
Run and check weather you are getting toast or not ?

[noties]

I'm really on a tight schedule right now 😅 . But if you wish to have click listener for both parent (it has some other views) and TextView - you can apply the same listener for both of them

[gbhaumikkumar14]

I'm really on a tight schedule right now 😅 . But if you wish to have click listener for both parent (it has some other views) and TextView - you can apply the same listener for both of them

Yeah that's last option. I have put some workaround it.

[berendn]

I'm experiencing the same issue.

[noties]

Unfortunately I do not know what can be done on our side, it seems to be a RecyclerView issue

[gbhaumikkumar14]

No, i have checked it's notrecyclerview problem. Because when i use normal setText that time everything seems normal. But when i put markwon.setMarkdown, problem is coming.

[noties]

I guess you would be surprised to know that internally Markwon is also just calling textView.setText ? 😉

[Kashish-Sharma]

Same issue here also, without Markwon, it works perfectly but with it, clicks are getting blocked!
Setting the same clickListener on the view using Markwon works, but then again if we're having a ripple or other animations on the whole view, those wont show now.

[yeduRaghav]

I face the same issue

[abalta]

I have same issue. See the following code.

` inner class ViewHolder(private val binding: ItemFastingBinding) :
RecyclerView.ViewHolder(binding.root) {

    private val markwon = Markwon.builder(binding.root.context).usePlugin(SoftBreakAddsNewLinePlugin.create()).build()

    fun bindView(item: Protocol) {
        binding.apply {
            markwon.setMarkdown(titleFasting, item.explanation?.en?.title?.breakLine().orEmpty())
            descFasting.text = item.explanation?.en?.desc?.breakLine().orEmpty()
            setDifficulty(item.difficulty)
            itemView.click {
                fastingItemClick(item, binding)
            }
        }
    }`

When I touch "titleFasting" view click method not trigger. But, I touch "descFasting" view click method is trigger normally.

And also, why this issue closed?

[berendn]

Maybe Markwon creates a clickable span or link span that consumes the click on the textview?

[Kashish-Sharma]

In my case, click event does work but the ripple animations etc, don't.

[noties]

@berendn, Markwon won't add link spans if there are no links in markdown, but it will apply the LinkMovementMethod if it is missing. Which actually is stealing parent touch events. So, if we do not have links in our markdown (@abalta), we can safely remove the movement method and everything will be ok:

markwon.setMarkdown(titleFasting, item.explanation?.en?.title?.breakLine().orEmpty())
titleFasting.movementMethod = null

This might be not optimal solution as modifying movement method rebuilds TextView display cache. I find it an oversight from Markwon to always apply LinkMovementMethod, so starting with the next version this can be controlled by using:

• configure CorePlugin#hasExplicitMovementMethodPlugin method (set true to disable implicit movement method)
• use plugin MovementMethodPlugin#none() factory method (which internally does the same as the first point)

---

This is all if your markdown doesn't have links. If you have - it seems that you will need to additionally apply click listener on the TextView itself (the same listener can be used for both itemView and textView). @Kashish-Sharma I believe this is what you are doing. But there is an issue with a touch feedback (ripple animation, etc). This also could be addressed by manually triggering parents background update. I've added TriggerParentHotspot in the sample application (develop branch) you can take a look.

Using this approach would allow both widgets to be clickable (TextView can also have links) and visual feedback will still be present and consistent. It can be used like this:

final View.OnClickListener listener = new View.OnClickListener() {
    @Override
    public void onClick(View v) {
        // clicked! 
    }
};

holder.itemView.setOnClickListener(listener);
holder.textView.setOnClickListener(listener);

// this would require for parent to have background
TriggerParentHotspot.init(holder.itemView, holder.textView);

[premacck]

I was also facing the same issue, but I wasn't using any clickables in the text, just other forms of formatting, so I just passed the touch events from the textView to the parent like this:

text_view.setOnTouchListener { _, event -> parent_view.onTouchEvent(event) }

This way it is also giving the ripple effect from the parent click

[Shunaylov]

@noties I can't find TriggerParentHotspot anymore, the url is not available now

[noties]

Hello @Shunaylov ,

it was lost during sample migration, but you still can find it in history