You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I was thinking about this some more. Perhaps we need to separate this schema into two parts.
What is allowed for blockchain RPC / smart contract calls
What is generally allowed
The original goal of the paramSchema on L9 was 2), but we are now limiting it to 1).
Solidity doesn't have floating point numbers, so limiting it to z.number().int() is fine. However, a JsonApiCondition can require floating point numbers. For example, the paramOrContextParamSchema is used for the value used for the returnValueTest () - and for a JSON API, checking a floating point number is perfectly fine, but now it won't be; typified by the fact that I saw you had to modify the floating point test.
I was thinking about this some more. Perhaps we need to separate this schema into two parts.
The original goal of the
paramSchema
on L9 was 2), but we are now limiting it to 1).Solidity doesn't have floating point numbers, so limiting it to
z.number().int()
is fine. However, aJsonApiCondition
can require floating point numbers. For example, theparamOrContextParamSchema
is used for the value used for the returnValueTest () - and for a JSON API, checking a floating point number is perfectly fine, but now it won't be; typified by the fact that I saw you had to modify the floating point test.Originally posted by @derekpierre in #598 (comment)
The text was updated successfully, but these errors were encountered: