New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Immutable components #4

Open

mikera opened this issue Feb 9, 2014 · 0 comments

Member

mikera commented Feb 9, 2014

We should remove mutable state from components.

Mutable state was originally included in components for performance reasons. However this seems to be counter-productive:

The performance gain is probably quite small as long as mutable vectors are used to accumulate gradient values (which is the expensive mutable step)
It means that defensive copying of components is required for concurrent use.
It's generally unidiomatic in Clojure to use mutable objects

This will require some significant refactoring, but is probably worth it to improve the overall Nurokit API

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment