Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jar file name for GitHub release #124

Open
Chongjx opened this issue Nov 9, 2020 · 5 comments
Open

jar file name for GitHub release #124

Chongjx opened this issue Nov 9, 2020 · 5 comments

Comments

@Chongjx
Copy link

Chongjx commented Nov 9, 2020

As per the instruction from the email, we renamed the jar file to the format [team ID][product name].jar but when we release on GitHub, the file name is converted to teamID.productName.jar. Would like to confirm that the file name for GitHub release is to be the same as the LumiNUS one.

image

@okkhoy
Copy link

okkhoy commented Nov 9, 2020

We primarily use the LumiNUS submissions for further evaluations. The JAR on GitHub is a back up + for completeness sake.
So it is OK if the GH release is named slightly differently.

@Chongjx
Copy link
Author

Chongjx commented Nov 9, 2020

Noted, thanks!

@farice9
Copy link

farice9 commented Nov 9, 2020

Borrowing this thread for a related issue. I noticed the example given in the email was :"[CS2113T-T12-1][Tasks Pro].jar".

Naming it this way might cause issue when running the program in command prompt due to space between "Tasks" and "Pro". Are we more advised to use "_" to replace spaces instead?

Edit: Realized we can use quotation " " to encapsulate the name. But would still appreciate the quick check!

@okkhoy
Copy link

okkhoy commented Nov 9, 2020

Use the one given in the email. Makes our life easier for processing before PE.

@farice9
Copy link

farice9 commented Nov 9, 2020

Noted, thanksss! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants