From 8d870a030937d7bc3a204da9ee11cb561fbbd554 Mon Sep 17 00:00:00 2001 From: Ian Vollick Date: Tue, 17 Apr 2018 18:48:13 +0000 Subject: [PATCH] [vr] Fix shadow offsets Gives the omnibox a soft shadow. Bug: 833375 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I17b9bbf4fdd2d8830e0157ddfd6b9ef57008ecb2 Reviewed-on: https://chromium-review.googlesource.com/1014010 Commit-Queue: Christopher Grant Reviewed-by: Christopher Grant Cr-Original-Commit-Position: refs/heads/master@{#551010}(cherry picked from commit a9741a3c07624404f14c5f32175335109d83e48c) Reviewed-on: https://chromium-review.googlesource.com/1015186 Reviewed-by: Ian Vollick Cr-Commit-Position: refs/branch-heads/3396@{#54} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} --- chrome/browser/vr/ui_scene_creator.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/chrome/browser/vr/ui_scene_creator.cc b/chrome/browser/vr/ui_scene_creator.cc index d037397b7cee2..184f00acdbb25 100644 --- a/chrome/browser/vr/ui_scene_creator.cc +++ b/chrome/browser/vr/ui_scene_creator.cc @@ -2415,7 +2415,7 @@ void UiSceneCreator::CreateOmnibox() { e->SetTransitionedProperties({}); y_offset += kUrlBarVerticalOffsetDMM; } - e->SetTranslate(0, y_offset, kOmniboxShadowOffset); + e->SetTranslate(0, y_offset, -kOmniboxShadowOffset); }, shadow.get()))); @@ -2623,6 +2623,7 @@ void UiSceneCreator::CreateOmnibox() { omnibox_background->set_hit_testable(true); omnibox_background->set_focusable(false); omnibox_background->set_corner_radius(kOmniboxCornerRadiusDMM); + omnibox_background->SetTranslate(0, 0, kOmniboxShadowOffset); VR_BIND_COLOR(model_, omnibox_background.get(), &ColorScheme::omnibox_background, &Rect::SetColor); omnibox_background->AddChild(std::move(omnibox_outer_layout));