Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write basic tests #8

Closed
WillNilges opened this issue Aug 25, 2023 · 7 comments
Closed

Write basic tests #8

WillNilges opened this issue Aug 25, 2023 · 7 comments
Assignees

Comments

@WillNilges
Copy link
Collaborator

Tests make the world go round :)

@andybaumgar andybaumgar self-assigned this Aug 25, 2023
@andybaumgar
Copy link
Collaborator

andybaumgar commented Aug 25, 2023

Started brainstorming in this Slack thread.

@WillNilges
Copy link
Collaborator Author

#27

@WillNilges
Copy link
Collaborator Author

Our README instructions are probably broken.

I don't think this will work in current state. We would need to add some config to pyproject.toml to tell pytest where to look for tests. Though I think we probably actually want to just use Django's wizardry to make this more pleasant and run python manage.py test instead per the recommendation in the docs: https://docs.djangoproject.com/en/4.2/topics/testing/overview/

@WillNilges
Copy link
Collaborator Author

manage.py test

@andybaumgar
Copy link
Collaborator

Should use standard Django testing method: https://docs.djangoproject.com/en/4.2/topics/testing/overview/

@Andrew-Dickinson
Copy link
Member

Andrew-Dickinson commented Sep 21, 2023

Acceptance criteria:

  • Have non-zero number of tests
  • Line coverage at 50% or higher
  • Readme instructions
    • for running existing tests
    • & how to add a new test

Out of scope:

  • Anything CI related. Okay to require devs to run tests manually. See Add CI #9

@Andrew-Dickinson Andrew-Dickinson changed the title Write tests Write basic tests Sep 21, 2023
@WillNilges
Copy link
Collaborator Author

#70

@WillNilges WillNilges self-assigned this Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants