Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate_mcpp.bat script seems to have stale paths #47

Open
siliconvoodoo opened this issue Jul 12, 2022 · 0 comments
Open

generate_mcpp.bat script seems to have stale paths #47

siliconvoodoo opened this issue Jul 12, 2022 · 0 comments
Labels
invalid This doesn't seem right priority/minor

Comments

@siliconvoodoo
Copy link
Contributor

@echo off
set DEVPATH=%1
set MCPP=%DEVPATH%\Gems\Atom\Asset\Shader\External\mcpp\2.7.2-az.1\lib\win_x64\mcpp.exe
set AZSLC=..\..\..\bin\win_x64\Release\azslc.exe
set DXC=%DEVPATH%\Gems\Atom\Asset\Shader\External\DirectXShaderCompiler\2020.08.07\bin\win_x64\Release\dxc.exe"

set AZSL=%2
set PREPROCESSED=%AZSL%.mcpp
set HLSL=%PREPROCESSED%.hlsl

rem %MCPP% %AZSL% > %PREPROCESSED%

%AZSLC% %PREPROCESSED% -o %HLSL%

rem %DXC% -help
rem %DXC% -T cs_6_2 %HLSL%
rem @echo on
rem %DXC% -T cs_6_2 main.azsl.mcpp.hlsl2.hlsl

If I understand correctly the changes that occurred for o3de release made that this test script cannot run from where it stands today.
It is in o3de-azslc\tests\Advanced\RespectEmitLine
I suspect that we need the introduction of an environment variable to be able to locate mcpp.exe which appears to be in o3de-packages\packages\mcpp-2.7.2_az.2-rev1-windows\mcpp\lib
(a python test script could also make the 2.7.2_.... part a non-necessary part with a regex like /mcpp-.*/)

@siliconvoodoo siliconvoodoo added invalid This doesn't seem right priority/minor labels Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right priority/minor
Projects
None yet
Development

No branches or pull requests

1 participant