From 002017020bf80632bbc0582d7ac2044f811ad112 Mon Sep 17 00:00:00 2001
From: Alzpetka <lili3.pokorna@seznam.cz>
Date: Mon, 9 Sep 2024 13:18:35 +0200
Subject: [PATCH] validation error

---
 oarepo_doi/api.py       | 11 +++++++----
 oarepo_doi/types/doi.py |  1 -
 2 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/oarepo_doi/api.py b/oarepo_doi/api.py
index 6c78b6c..fb413a4 100644
--- a/oarepo_doi/api.py
+++ b/oarepo_doi/api.py
@@ -2,11 +2,11 @@
 import uuid
 
 import requests
-from flask import current_app
 from invenio_access.permissions import system_identity
 from invenio_base.utils import obj_or_import_string
 from invenio_communities import current_communities
 from invenio_search.engine import dsl
+from marshmallow.exceptions import ValidationError
 from oarepo_runtime.datastreams.utils import get_record_service_for_record
 
 
@@ -19,8 +19,9 @@ def create_doi(service, record, data, event=None):
     record["links"] = record_service.links_item_tpl.expand(system_identity, record)
 
     if len(errors) > 0 and event:
-        return  # todo: dois can not be published with missing mandatory values
-
+        raise ValidationError(
+            message=f"Could not assigned doi due to validation error: {errors} "
+        )
     request_metadata = {"data": {"type": "dois", "attributes": {}}}
 
     payload = mapping.create_datacite_payload(data)
@@ -59,7 +60,9 @@ def edit_doi(service, record, event=None):
     record_service = get_record_service_for_record(record)
     record["links"] = record_service.links_item_tpl.expand(system_identity, record)
     if len(errors) > 0 and event:
-        return  # todo: dois can not be published with missing mandatory values
+        raise ValidationError(
+            message=f"Could not assigned doi due to validation error: {errors} "
+        )
 
     doi_value = mapping.get_doi(record)
     if doi_value:
diff --git a/oarepo_doi/types/doi.py b/oarepo_doi/types/doi.py
index a9cb9de..23a4a30 100644
--- a/oarepo_doi/types/doi.py
+++ b/oarepo_doi/types/doi.py
@@ -1,6 +1,5 @@
 from flask import current_app
 from invenio_base.utils import obj_or_import_string
-from invenio_requests.customizations import RequestType
 from marshmallow.exceptions import ValidationError
 from oarepo_requests.types.generic import NonDuplicableOARepoRequestType
 from oarepo_requests.types.ref_types import ModelRefTypes