Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the CRB to implement 0.24 API version #7

Open
vjtirumalai opened this issue Oct 16, 2017 · 3 comments
Open

Modify the CRB to implement 0.24 API version #7

vjtirumalai opened this issue Oct 16, 2017 · 3 comments
Assignees

Comments

@vjtirumalai
Copy link
Member

  • Make sure the functional tests work
  • Make sure mysql dsb functional tests work (it also deploys CRB and validates copy restore workflow)
@shpandrak
Copy link
Member

Having the mysql-dsb functional tests rely on the cf-crb was a mistake. This is another proof.. but never mind, I will keep it as is...

@vjtirumalai
Copy link
Member Author

The functional tests are validating copy restore workflow end to end which requires a DSB and CRB.
Do propose what you have in mind for a "functional test"? Lets talk after you have a proposal.

@shpandrak
Copy link
Member

@vjtirumalai The mysql dsb does not rely on "a CRB" for functional tests. all it needs is something that implements "shapnRest" protocol.
(The DSBs are not and should not be familiar with the CRB concept - only protocols for copying data)
Implementing a service with the "shpanRest" protocol is a few lines of code... only need post data and get data... my proposal is to implement that and not rely on a another service that might change in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants