Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ODK-X Services Test Coverage: Write Test for service class in the Application package #505

Open
Agaba-derrick opened this issue Oct 9, 2024 · 2 comments

Comments

@Agaba-derrick
Copy link

Agaba-derrick commented Oct 9, 2024

The Services class in the org.opendatakit/services/application package extends ToolAwareApplication and implements IToolAware. This class manages Firebase Analytics initialization and logging upon app creation, and includes a deprecated method to get a context instance.

Tasks for this issue:

  • Write unit tests to ensure the correct initialization and logging of Firebase Analytics events.
  • Test the singleton implementation and ensure the _please_dont_use_getInstance() method behaves as expected, even though it is deprecated.
  • Verify that the getApkDisplayNameResourceId() method returns the correct resource ID.

This issue aims to improve code coverage and ensure the stability of the Services class functionality.
fix for #504

@Agaba-derrick
Copy link
Author

@wbrunette @Lamouresparus
am working on this ticket

@Lamouresparus
Copy link

Lamouresparus commented Oct 13, 2024

@Agaba-derrick
I will suggest that you work on #507 first, as that is more beginner friendly, before working on this. But if you feel confident, you can go ahead :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants