Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checklist #27

Open
15 of 23 tasks
omkarakatta opened this issue Feb 15, 2021 · 5 comments
Open
15 of 23 tasks

Checklist #27

omkarakatta opened this issue Feb 15, 2021 · 5 comments

Comments

@omkarakatta
Copy link
Owner

omkarakatta commented Feb 15, 2021

  • Evaluate empirical costs at all bandwidths, not just "acceptable" bandwidths
  • Add sections to code
  • Choose better names for output objects
  • Remove unnecessary arguments
  • Error checks
    • check that pre_main_subsample_size and others is not NULL before checking it is an integer
    • choose defaults for subsample size? maybe not
    • ignore *_control_subsample_size if estimator is "ba"
  • Update documentation
  • Create print and summary methods
    • print --- basic output
    • summary --- full output
    • summary_placebo --- summarize placebo results
    • summary_subsample --- summarize subsample results
  • Create plot and table methods
    • plot_data_hist --- overlayed histograms of pre- and post-distributions
    • plot_placebo_summary --- plot summary results of placebo vs. bandwidth
    • plot_empirical --- plot empirical results vs. bandwidth
      • add option for plotting placebo as well
      • add option for plotting treated and control, not just the difference
    • plot_placebo --- plot placebo results vs. bandwidth (add option for plotting empirical as well)
    • plot_subsample --- plot histogram of subsample results
  • Create retrieval methods
    • retrieve_placebo --- send placebo results
    • retrieve_subsample --- send subsample results
    • retrieve_empirical --- send empirical results
@omkarakatta
Copy link
Owner Author

omkarakatta commented Feb 17, 2021

  • order bandwidth_vec; take unique values; ensure that it has non-zero length

@omkarakatta
Copy link
Owner Author

  • Find a way to hide the vlines and hlines

@omkarakatta
Copy link
Owner Author

  • Fix the default bandwidth selection criterion for difference-in-transports estimator (use d-d for bandwidth selection and use 2d-d for empirical computation and subsampling); allow option to use 2d-d for bandwidth selection criterion
  • Go over subsampling procedure

@omkarakatta
Copy link
Owner Author

omkarakatta commented Mar 5, 2021

  • Organize main and control distributions so they are in order according to the support
  • Ensure that placebo is less than 0.05% (before-and-after)

@omkarakatta
Copy link
Owner Author

  • Choose a random seed as default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant