Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README walkthrough #8

Open
sisyphusSmiling opened this issue Dec 8, 2023 · 0 comments
Open

Update README walkthrough #8

sisyphusSmiling opened this issue Dec 8, 2023 · 0 comments
Labels
documentation Improvements or additions to documentation

Comments

@sisyphusSmiling
Copy link
Contributor

Description

The update execution noted in the README walkthrough will not succeed since the update contracts (./contract/test/A_update.cdc, etc.) include hard-coded Test addresses, necessarily so for the Cadence test suite.

Suggested Solution

README should either remove the walkthrough altogether or updated contracts should be segmented between example/ and test/ and updated in flow.json to distinguish test suite and walkthrough hardcoded addresses
@sisyphusSmiling sisyphusSmiling added the documentation Improvements or additions to documentation label Dec 8, 2023
@sisyphusSmiling sisyphusSmiling changed the title Update README's CLI walkthrough Update README walkthrough Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sisyphusSmiling