Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable hpa-values.yaml test in helm charts e2e test in CI #414

Open
daisy-ycguo opened this issue Sep 9, 2024 · 1 comment
Open

enable hpa-values.yaml test in helm charts e2e test in CI #414

daisy-ycguo opened this issue Sep 9, 2024 · 1 comment
Assignees
Labels

Comments

@daisy-ycguo
Copy link
Collaborator

No description provided.

@daisy-ycguo daisy-ycguo self-assigned this Sep 9, 2024
@eero-t
Copy link
Contributor

eero-t commented Oct 4, 2024

@daisy-ycguo CI needs Prometheus for testing hpa-values.yaml: https://github.com/opea-project/GenAIInfra/blob/main/helm-charts/HPA.md#prometheus

Otherwise Helm install fails due to missing serviceMonitor and custom metrics Kubernetes APIs.

As to testing that the HPA rules actually work, there's a manual step needed for installing the required custom metric config. That part can be scripted in few lines, shown here: https://github.com/opea-project/GenAIInfra/blob/main/helm-charts/HPA.md#post-install

TGI and TEI services enabled their metrics enpoints only after processing their first request. I.e. verifying that that HPA can access the relevant custom metrics, requires uploading doc(s) with data-prep so that reranking is used, and doing at least one ChatQnA query. Then HPA can be verified to be working:
https://github.com/opea-project/GenAIInfra/blob/main/helm-charts/HPA.md#verify

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants