Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate code review coding standard #4

Open
polothy opened this issue Sep 23, 2015 · 1 comment
Open

Integrate code review coding standard #4

polothy opened this issue Sep 23, 2015 · 1 comment

Comments

@polothy
Copy link
Contributor

polothy commented Sep 23, 2015

Review and then integrate https://github.com/mrmark/joule-plugincheck as a new command, like moodle-plugin-ci codereview

The project should be moved into moodlerooms Github account and should be managed similarly to https://github.com/moodlerooms/moodle-coding-standard.

The point of the new standard is to add additional checks that do not make sense for the Moodle coding standard, but are required by Moodlerooms or Moodle partners in general.

@polothy
Copy link
Contributor Author

polothy commented Sep 29, 2015

Note, with recent changes, we can probably just update the StandardResolver class and then run this by doing: moodle-plugin-ci codechecker --standard NAME. This is instead of adding a whole new command. Rest of the issue description is still valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant