Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builder: Please retain functionality to supply Go binary at command time #11453

Open
braydonk opened this issue Oct 15, 2024 · 1 comment
Open

Comments

@braydonk
Copy link
Contributor

braydonk commented Oct 15, 2024

Is your feature request related to a problem? Please describe.
My intended setup for a collector binary built by OCB is the following:

  • Write a manifest.yaml
  • Download a local copy of a Go binary at a specific version
  • Use that Go binary to install a local copy of builder
  • Provide the locally installed Go binary as the Go binary for builder, today using the --go flag

This flag is being deprecated in favour of the distribution::go config value. However in my desired setup, I would have to separately track within the manifest the eventual location of the Go binary that I'm going to install when it's time to build. It is logically much cleaner to simply provide the Go binary I want at command-time rather than being forced to track this in configuration.

Describe the solution you'd like
Either keep the --go flag, or provide something other mechanism to provide a Go binary at command-time like an env var.

Describe alternatives you've considered
As stated above, I could just track the location that I know the local Go binary will be installed when it is, but this is less clean than simply providing it at command-time.

@mx-psi
Copy link
Member

mx-psi commented Oct 16, 2024

Relates to #7976

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants