Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renovate: skip commit upgrades of otel-go #6192

Open
dmathieu opened this issue Oct 4, 2024 · 1 comment
Open

Renovate: skip commit upgrades of otel-go #6192

dmathieu opened this issue Oct 4, 2024 · 1 comment
Assignees
@Victorsesan
Labels
bug Something isn't working

Comments

@dmathieu
Copy link
Member

dmathieu commented Oct 4, 2024

Description

#6144 was aiming to skip commit upgrades of renovate, but it appears that didn't do anything, since we still have the PRs: #6180

We should have renovate skip upgrades of otel-go if the dependency is on a commit, and only upgrade to the next release.
@dmathieu dmathieu added the bug Something isn't working label Oct 4, 2024
@dmathieu dmathieu changed the title Renovate: kip commit upgrades of otel-go Renovate: skip commit upgrades of otel-go Oct 9, 2024
@Victorsesan
Copy link

@dmathieu Please let me give this one a try, i might be wrong but based on the PRs if it requires modifying the renovate.json file to include rules that skip commit-based dependencies i could give it a try and you review

Victorsesan added a commit to Victorsesan/opentelemetry-go-contrib that referenced this issue Oct 11, 2024
@Victorsesan
I have dded an ignore property under the matchPackageNames rule to di…
6669a57 
…sable updates when the dependency is pinned to a specific commit or digest. The final rule ensures no updates are applied if the dependency's version source URL is a commit SHA.

Related to open-telemetry#6192
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Victorsesan Victorsesan

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dmathieu @Victorsesan