Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port RuleBasedSampler to opentelemetry-php-contrib #1218

Closed
brettmc opened this issue Jan 19, 2024 · 1 comment
Closed

port RuleBasedSampler to opentelemetry-php-contrib #1218

brettmc opened this issue Jan 19, 2024 · 1 comment
Labels
good first issue Good for newcomers help wanted This issue is looking for someone to work on it medium medium sized task

Comments

@brettmc
Copy link
Collaborator

brettmc commented Jan 19, 2024

A proof-of-concept sampler, https://github.com/Nevay/otel-sdk-contrib-sampler was created to demonstrate a rules-based sampler, as an improvement over the sampler proposed in #1208 .
A RuleBasedSampler is mentioned in open-telemetry/oteps#240

Since a Rule-based sampler is not part of the otel specification, it should initially live in opentelemetry-php-contrib repo. It won't be initially supported to enable/configure via environment variables, but it can be configured via code. If the above OTEP is accepted and implemented, then we can use that mechanism to automatically enable/configure the sampler.

If it can be implemented without adding external dependencies (eg symfony/config) that will help if it ever becomes a core component (since we try to minimize dependencies, and code to interfaces).

@brettmc brettmc added help wanted This issue is looking for someone to work on it good first issue Good for newcomers medium medium sized task labels Jan 19, 2024
@ChrisLightfootWild
Copy link
Contributor

Implemented in open-telemetry/opentelemetry-php-contrib#279

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted This issue is looking for someone to work on it medium medium sized task
Projects
None yet
Development

No branches or pull requests

2 participants