Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add retry support and custom timeout options to the connect method #9

Open
tcortega opened this issue Jan 10, 2023 · 2 comments

Comments

@tcortega
Copy link
Contributor

It is useful to have retry support, specially if the user is running everything in a containerized environment.

I personally have a scenario in which the api runs and the socket client starts right after it, but the problem is that even if the API container is running, it does not mean that it has finished starting and setting everything up.

Adding retry support would be extremely useful in scenarios like mine, and some others.

@smashah
Copy link
Member

smashah commented Jan 13, 2023

@tcortega can you share some basic code where this would come into use?

@smashah
Copy link
Member

smashah commented Jan 16, 2023

Maybe instead we can do this:

  • Expose socket events on the SocketClient (e.g socketClient.onConnected() etc.
  • Update Docs to use onConnected etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants