diff --git a/api/v1alpha1/dspipeline_types.go b/api/v1alpha1/dspipeline_types.go index 72af4a3f9..1dcb30a9c 100644 --- a/api/v1alpha1/dspipeline_types.go +++ b/api/v1alpha1/dspipeline_types.go @@ -150,8 +150,8 @@ type APIServer struct { // The expiry time (seconds) for artifact download links when // querying the dsp server via /apis/v2beta1/artifacts/{id}?share_url=true - // Default: 15 - // +kubebuilder:default:=15 + // Default: 60 + // +kubebuilder:default:=60 // +kubebuilder:validation:Optional ArtifactSignedURLExpirySeconds *int `json:"artifactSignedURLExpirySeconds"` } diff --git a/config/crd/bases/datasciencepipelinesapplications.opendatahub.io_datasciencepipelinesapplications.yaml b/config/crd/bases/datasciencepipelinesapplications.opendatahub.io_datasciencepipelinesapplications.yaml index d28b446b9..a8af2afb7 100644 --- a/config/crd/bases/datasciencepipelinesapplications.opendatahub.io_datasciencepipelinesapplications.yaml +++ b/config/crd/bases/datasciencepipelinesapplications.opendatahub.io_datasciencepipelinesapplications.yaml @@ -68,10 +68,10 @@ spec: type: string type: object artifactSignedURLExpirySeconds: - default: 15 + default: 60 description: 'The expiry time (seconds) for artifact download links when querying the dsp server via /apis/v2beta1/artifacts/{id}?share_url=true - Default: 15' + Default: 60' type: integer autoUpdatePipelineDefaultVersion: default: true diff --git a/controllers/config/defaults.go b/controllers/config/defaults.go index 8dcb620fb..412254d96 100644 --- a/controllers/config/defaults.go +++ b/controllers/config/defaults.go @@ -60,7 +60,7 @@ const ( DefaultDBSecretKey = "password" GeneratedDBPasswordLength = 12 - DefaultSignedUrlExpiryTimeSeconds = 15 + DefaultSignedUrlExpiryTimeSeconds = 60 MariaDBName = "mlpipeline" MariaDBHostPrefix = "mariadb" diff --git a/controllers/testdata/declarative/case_0/expected/created/apiserver_deployment.yaml b/controllers/testdata/declarative/case_0/expected/created/apiserver_deployment.yaml index 35eec3d89..8b92f211f 100644 --- a/controllers/testdata/declarative/case_0/expected/created/apiserver_deployment.yaml +++ b/controllers/testdata/declarative/case_0/expected/created/apiserver_deployment.yaml @@ -80,7 +80,7 @@ spec: - name: ML_PIPELINE_SERVICE_PORT_GRPC value: "8887" - name: SIGNED_URL_EXPIRY_TIME_SECONDS - value: "15" + value: "60" - name: EXECUTIONTYPE value: PipelineRun - name: CACHE_IMAGE diff --git a/controllers/testdata/declarative/case_2/expected/created/apiserver_deployment.yaml b/controllers/testdata/declarative/case_2/expected/created/apiserver_deployment.yaml index d656ff5b7..810ddfc1c 100644 --- a/controllers/testdata/declarative/case_2/expected/created/apiserver_deployment.yaml +++ b/controllers/testdata/declarative/case_2/expected/created/apiserver_deployment.yaml @@ -80,7 +80,7 @@ spec: - name: ML_PIPELINE_SERVICE_PORT_GRPC value: "8887" - name: SIGNED_URL_EXPIRY_TIME_SECONDS - value: "15" + value: "60" - name: EXECUTIONTYPE value: PipelineRun - name: CACHE_IMAGE diff --git a/controllers/testdata/declarative/case_3/expected/created/apiserver_deployment.yaml b/controllers/testdata/declarative/case_3/expected/created/apiserver_deployment.yaml index 3f7ccd43f..c79819661 100644 --- a/controllers/testdata/declarative/case_3/expected/created/apiserver_deployment.yaml +++ b/controllers/testdata/declarative/case_3/expected/created/apiserver_deployment.yaml @@ -80,7 +80,7 @@ spec: - name: ML_PIPELINE_SERVICE_PORT_GRPC value: "8887" - name: SIGNED_URL_EXPIRY_TIME_SECONDS - value: "15" + value: "60" - name: EXECUTIONTYPE value: PipelineRun - name: CACHE_IMAGE diff --git a/controllers/testdata/declarative/case_4/expected/created/apiserver_deployment.yaml b/controllers/testdata/declarative/case_4/expected/created/apiserver_deployment.yaml index 6d163e59a..16131faad 100644 --- a/controllers/testdata/declarative/case_4/expected/created/apiserver_deployment.yaml +++ b/controllers/testdata/declarative/case_4/expected/created/apiserver_deployment.yaml @@ -80,7 +80,7 @@ spec: - name: ML_PIPELINE_SERVICE_PORT_GRPC value: "8887" - name: SIGNED_URL_EXPIRY_TIME_SECONDS - value: "15" + value: "60" - name: EXECUTIONTYPE value: PipelineRun - name: CACHE_IMAGE diff --git a/controllers/testdata/declarative/case_5/expected/created/apiserver_deployment.yaml b/controllers/testdata/declarative/case_5/expected/created/apiserver_deployment.yaml index c5be15a7b..8f1937885 100644 --- a/controllers/testdata/declarative/case_5/expected/created/apiserver_deployment.yaml +++ b/controllers/testdata/declarative/case_5/expected/created/apiserver_deployment.yaml @@ -84,7 +84,7 @@ spec: - name: ML_PIPELINE_SERVICE_PORT_GRPC value: "8887" - name: SIGNED_URL_EXPIRY_TIME_SECONDS - value: "15" + value: "60" - name: EXECUTIONTYPE value: PipelineRun - name: CACHE_IMAGE diff --git a/controllers/testdata/declarative/case_7/expected/created/apiserver_deployment.yaml b/controllers/testdata/declarative/case_7/expected/created/apiserver_deployment.yaml index c2e090ecc..b9603e2df 100644 --- a/controllers/testdata/declarative/case_7/expected/created/apiserver_deployment.yaml +++ b/controllers/testdata/declarative/case_7/expected/created/apiserver_deployment.yaml @@ -84,7 +84,7 @@ spec: - name: ML_PIPELINE_SERVICE_PORT_GRPC value: "8887" - name: SIGNED_URL_EXPIRY_TIME_SECONDS - value: "15" + value: "60" - name: EXECUTIONTYPE value: Workflow - name: DB_DRIVER_NAME diff --git a/controllers/testdata/declarative/case_8/expected/created/apiserver_deployment.yaml b/controllers/testdata/declarative/case_8/expected/created/apiserver_deployment.yaml index 363525244..ae01ded70 100644 --- a/controllers/testdata/declarative/case_8/expected/created/apiserver_deployment.yaml +++ b/controllers/testdata/declarative/case_8/expected/created/apiserver_deployment.yaml @@ -92,7 +92,7 @@ spec: - name: ML_PIPELINE_SERVICE_PORT_GRPC value: "8887" - name: SIGNED_URL_EXPIRY_TIME_SECONDS - value: "15" + value: "60" - name: ML_PIPELINE_TLS_ENABLED value: "true" - name: EXECUTIONTYPE diff --git a/controllers/testdata/declarative/case_9/expected/created/apiserver_deployment.yaml b/controllers/testdata/declarative/case_9/expected/created/apiserver_deployment.yaml index 788b2faaf..be53d39ba 100644 --- a/controllers/testdata/declarative/case_9/expected/created/apiserver_deployment.yaml +++ b/controllers/testdata/declarative/case_9/expected/created/apiserver_deployment.yaml @@ -84,7 +84,7 @@ spec: - name: ML_PIPELINE_SERVICE_PORT_GRPC value: "8887" - name: SIGNED_URL_EXPIRY_TIME_SECONDS - value: "15" + value: "60" - name: EXECUTIONTYPE value: Workflow - name: DB_DRIVER_NAME