Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What happens when OpenShift API library is updated to github.com/openshift/api v0.0.0-20210416115537-a60c0dc032fd? #361

Open
jiridanek opened this issue Jun 28, 2024 · 1 comment
Open

What happens when OpenShift API library is updated to github.com/openshift/api v0.0.0-20210416115537-a60c0dc032fd? #361

jiridanek opened this issue Jun 28, 2024 · 1 comment
Labels
question Further information is requested

Comments

@jiridanek
Copy link
Member

/kind question

Question:

What happens when OpenShift API library is updated from

github.com/openshift/api v0.0.0-20190924102528-32369d4db2ad

to

github.com/openshift/api v0.0.0-20210416115537-a60c0dc032fd

?

Answer:

 2024-06-28T17:34:36Z	ERROR	controllers.notebook-controller	Unable to create the Route	{"notebook": "test-notebook", "namespace": "default", "error": "Route.route.openshift.io \"test-notebook\" is invalid: [spec.host: Required value, status.ingress: Required value]"}
github.com/opendatahub-io/kubeflow/components/odh-notebook-controller/controllers.(*OpenshiftNotebookReconciler).reconcileRoute
	/home/runner/work/kubeflow/kubeflow/components/odh-notebook-controller/controllers/notebook_route.go:104
github.com/opendatahub-io/kubeflow/components/odh-notebook-controller/controllers.(*OpenshiftNotebookReconciler).ReconcileRoute
	/home/runner/work/kubeflow/kubeflow/components/odh-notebook-controller/controllers/notebook_route.go:145
github.com/opendatahub-io/kubeflow/components/odh-notebook-controller/controllers.(*OpenshiftNotebookReconciler).Reconcile
	/home/runner/work/kubeflow/kubeflow/components/odh-notebook-controller/controllers/notebook_controller.go:215
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile
	/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.5/pkg/internal/controller/controller.go:119
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
	/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.5/pkg/internal/controller/controller.go:316
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
	/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.5/pkg/internal/controller/controller.go:266
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
	/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.5/pkg/internal/controller/controller.go:227
2024-06-28T17:34:36Z	ERROR	Reconciler error	{"controller": "notebook", "controllerGroup": "kubeflow.org", "controllerKind": "Notebook", "Notebook": {"name":"test-notebook","namespace":"default"}, "namespace": "default", "name": "test-notebook", "reconcileID": "f06ee7fb-f9ad-4553-a07b-3bf3bc7009ba", "error": "Route.route.openshift.io \"test-notebook\" is invalid: [spec.host: Required value, status.ingress: Required value]"}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
	/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.5/pkg/internal/controller/controller.go:329
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
	/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.5/pkg/internal/controller/controller.go:266
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
	/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.5/pkg/internal/controller/controller.go:227
2024-06-28T17:34:36Z	INFO	controllers.notebook-controller	Creating Route	{"notebook": "test-notebook", "namespace": "default"}
2024-06-28T17:34:36Z	ERROR	controllers.notebook-controller	Unable to create the Route	{"notebook": "test-notebook", "namespace": "default", "error": "Route.route.openshift.io \"test-notebook\" is invalid: [spec.host: Required value, status.ingress: Required value]"}
github.com/opendatahub-io/kubeflow/components/odh-notebook-controller/controllers.(*OpenshiftNotebookReconciler).reconcileRoute
	/home/runner/work/kubeflow/kubeflow/components/odh-notebook-controller/controllers/notebook_route.go:104
github.com/opendatahub-io/kubeflow/components/odh-notebook-controller/controllers.(*OpenshiftNotebookReconciler).ReconcileRoute
	/home/runner/work/kubeflow/kubeflow/components/odh-notebook-controller/controllers/notebook_route.go:145
github.com/opendatahub-io/kubeflow/components/odh-notebook-controller/controllers.(*OpenshiftNotebookReconciler).Reconcile
	/home/runner/work/kubeflow/kubeflow/components/odh-notebook-controller/controllers/notebook_controller.go:215
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile
	/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.5/pkg/internal/controller/controller.go:119
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
	/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.5/pkg/internal/controller/controller.go:316
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
	/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.5/pkg/internal/controller/controller.go:266
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
	/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.5/pkg/internal/controller/controller.go:227

And what happens when the latest version is used? Package does not compile on go1.21 and go1.22 is needed.
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 28, 2024

@jiridanek: The label(s) kind/question cannot be applied, because the repository doesn't have them.

In response to this:

/kind question

Question:

What happens when OpenShift API library is updated from

github.com/openshift/api v0.0.0-20190924102528-32369d4db2ad

to

github.com/openshift/api v0.0.0-20210416115537-a60c0dc032fd

?

Answer:

2024-06-28T17:34:36Z	ERROR	controllers.notebook-controller	Unable to create the Route	{"notebook": "test-notebook", "namespace": "default", "error": "Route.route.openshift.io \"test-notebook\" is invalid: [spec.host: Required value, status.ingress: Required value]"}
github.com/opendatahub-io/kubeflow/components/odh-notebook-controller/controllers.(*OpenshiftNotebookReconciler).reconcileRoute
  /home/runner/work/kubeflow/kubeflow/components/odh-notebook-controller/controllers/notebook_route.go:104
github.com/opendatahub-io/kubeflow/components/odh-notebook-controller/controllers.(*OpenshiftNotebookReconciler).ReconcileRoute
  /home/runner/work/kubeflow/kubeflow/components/odh-notebook-controller/controllers/notebook_route.go:145
github.com/opendatahub-io/kubeflow/components/odh-notebook-controller/controllers.(*OpenshiftNotebookReconciler).Reconcile
  /home/runner/work/kubeflow/kubeflow/components/odh-notebook-controller/controllers/notebook_controller.go:215
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile
  /home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.5/pkg/internal/controller/controller.go:119
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
  /home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.5/pkg/internal/controller/controller.go:316
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
  /home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.5/pkg/internal/controller/controller.go:266
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
  /home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.5/pkg/internal/controller/controller.go:227
2024-06-28T17:34:36Z	ERROR	Reconciler error	{"controller": "notebook", "controllerGroup": "kubeflow.org", "controllerKind": "Notebook", "Notebook": {"name":"test-notebook","namespace":"default"}, "namespace": "default", "name": "test-notebook", "reconcileID": "f06ee7fb-f9ad-4553-a07b-3bf3bc7009ba", "error": "Route.route.openshift.io \"test-notebook\" is invalid: [spec.host: Required value, status.ingress: Required value]"}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
  /home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.5/pkg/internal/controller/controller.go:329
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
  /home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.5/pkg/internal/controller/controller.go:266
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
  /home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.5/pkg/internal/controller/controller.go:227
2024-06-28T17:34:36Z	INFO	controllers.notebook-controller	Creating Route	{"notebook": "test-notebook", "namespace": "default"}
2024-06-28T17:34:36Z	ERROR	controllers.notebook-controller	Unable to create the Route	{"notebook": "test-notebook", "namespace": "default", "error": "Route.route.openshift.io \"test-notebook\" is invalid: [spec.host: Required value, status.ingress: Required value]"}
github.com/opendatahub-io/kubeflow/components/odh-notebook-controller/controllers.(*OpenshiftNotebookReconciler).reconcileRoute
  /home/runner/work/kubeflow/kubeflow/components/odh-notebook-controller/controllers/notebook_route.go:104
github.com/opendatahub-io/kubeflow/components/odh-notebook-controller/controllers.(*OpenshiftNotebookReconciler).ReconcileRoute
  /home/runner/work/kubeflow/kubeflow/components/odh-notebook-controller/controllers/notebook_route.go:145
github.com/opendatahub-io/kubeflow/components/odh-notebook-controller/controllers.(*OpenshiftNotebookReconciler).Reconcile
  /home/runner/work/kubeflow/kubeflow/components/odh-notebook-controller/controllers/notebook_controller.go:215
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile
  /home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.5/pkg/internal/controller/controller.go:119
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
  /home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.5/pkg/internal/controller/controller.go:316
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
  /home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.5/pkg/internal/controller/controller.go:266
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
  /home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.5/pkg/internal/controller/controller.go:227

And what happens when the latest version is used? Package does not compile on go1.21 and go1.22 is needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jiridanek jiridanek added the question Further information is requested label Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jiridanek