Can't compare structs that contain pointers with ==

[jiridanek]

/kind bug

What steps did you take and what happened:

kubeflow/components/notebook-controller/controllers/notebook_controller.go

Lines 319 to 321 in e5894a3

	if pod.Status.ContainerStatuses[i].State == nb.Status.ContainerState {
	continue
	}

There, even if

reflect.DeepEqual(pod.Status.ContainerStatuses[i].State, nb.Status.ContainerState)

returns true, that == will give us false because status contains references, not direct values.

What you expect

We should look into https://github.com/google/go-cmp, or cmp.Equal, or reflect.DeepEqual and use one of these.

Or maybe the k8s compare function, apiequality.Semantic.DeepEqual, see https://godoc.org/k8s.io/apimachinery/pkg/api/equality)

Note:

Trying this out in debugger is annoying because of

• Support conversion to interface type in function calls go-delve/delve#1575