-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request]: Improve Notebook Logout Experience #892
Comments
@DaoDaoNoCode Would you be able to test this and see if you solved this with your recent changes to logout in DS Projects. Test both Jupyter Tile & DS Projects Workbench logout. |
Test results with the changes in #1792 Data science project: Jupyter tile: So the issue is still there and we may need to figure out a way to better handle it. |
On Notebook-controller end, we are also trying to find a solution on our end for this. |
Similar but not the same issue @harshad16 -- that, however, has been discussed before so I'm glad you have something logged 🎉 This is about when our Dashboard hard refreshes/redirects after being sent back from JupyterLab -- this should be entirely a flow on our side as I understand the issue. |
Thank you for clarifying the difference, if we find some insights |
Migrated to: https://issues.redhat.com/browse/RHOAIENG-2744 |
Feature description
When logging out of the Jupyter Notebook it redirects to our Dashboard -- which uses a
window.location
redirect to the OAuth container for that Notebook -- which then redirects back to us at a more specific location (either the control panel for the jupyter tile or the project the notebook belongs to).What we should do is look to see if we can make a direct get call or something using
fetch
oraxios
or something -- when we get a response, we can react-router redirect and keep the flow a lot cleaner.It's a messy back and forth right now.
Describe alternatives you've considered
Possible we spawn a new tab to do this? Not sure this is any more ideal -- and browsers could probably mute this action so we might be out of luck if the primary goal fails.
Anything else?
No response
The text was updated successfully, but these errors were encountered: