Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Missing ClusterRole "prometheus-ns-access" #121

Open
VedantMahabaleshwarkar opened this issue Nov 22, 2023 · 1 comment
Open

Bug: Missing ClusterRole "prometheus-ns-access" #121

VedantMahabaleshwarkar opened this issue Nov 22, 2023 · 1 comment
Assignees

Comments

@VedantMahabaleshwarkar
Copy link
Contributor

Context:

Odh-model-controller originally was developed with the modelmesh-monitoring stack in mind. This modelmesh-monitoring component is now deprecated and odh-model-controller should not depend on it.

Short term solution if needed :
Add missing rbac files from https://github.com/opendatahub-io/odh-manifests/tree/master/modelmesh-monitoring/base/prometheus/rbac to odh-model-controller manifests to get rid of the error.

Long term solution:
Remove logic from odh-model-controller that involves the modelmesh-monitoring component

@davidesalerno
Copy link

@VedantMahabaleshwarkar what do you think if for 2.5 we will leave things AS-IS and we will go for the long term solution for 2.6?
The errors that at the moment are raised from the odh-model-controller are not fatal and so they could be considered more as warnings and so "suppressed".

cc @vaibhavjainwiz @danielezonca

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Status: No status
Status: In Progress
Development

No branches or pull requests

2 participants