Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add errors/warnings in the logs if metrics cannot be captured #79

Open
bdattoma opened this issue Sep 5, 2023 · 0 comments
Open

Add errors/warnings in the logs if metrics cannot be captured #79

bdattoma opened this issue Sep 5, 2023 · 0 comments

Comments

@bdattoma
Copy link

bdattoma commented Sep 5, 2023

While testing, we noticed that is there is an issue with capturing the metrics which are exposed by kserve/caikit/istio, the odh-model-controller doesn't report any error or warning. It keeps printing out something like:

1.693903864744821e+09	INFO	controllers.InferenceService	Reconciling Metrics ServiceMonitor for InferenceSercvice	{"InferenceService": "<isvc_name>", "namespace": "<test_ns>"}
1.6939038647538376e+09	INFO	controllers.InferenceService	Metrics ServiceMonitor already exists for InferenceService	{"InferenceService": "<isvc_name>", "namespace": "<test_ns>"}

It would be helpful to have a line in the logs saying that there isn't something working fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Status: No status
Status: New/Backlog
Development

No branches or pull requests

1 participant