Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support password protected/encrypted files #351

Open
marcel263 opened this issue Jun 6, 2024 · 9 comments
Open

Support password protected/encrypted files #351

marcel263 opened this issue Jun 6, 2024 · 9 comments
Assignees

Comments

@marcel263
Copy link

The app v 3.26 refused to open password-protected xlsx file. It gave a warning "unsupported file". LibreOffice desktop would open it, prompting for password.

@andiwand
Copy link
Member

andiwand commented Jun 6, 2024

@TomTasche do you know if this runs the core backend or the online one?

@TomTasche
Copy link
Member

@marcel263
Copy link
Author

Apologies I assumed the app would support various types of OpenDocument formats

@marcel263 marcel263 closed this as not planned Won't fix, can't repro, duplicate, stale Jun 7, 2024
@andiwand
Copy link
Member

andiwand commented Jun 7, 2024

I think this should work @marcel263 - does this only show up for a single file or all of the encrypted XLSX? In case this only happens for a specific file would you be able to share it with us?

@andiwand andiwand reopened this Jun 7, 2024
@andiwand
Copy link
Member

andiwand commented Jun 9, 2024

encrypted.xlsx password

Could not reproduce the problem in core but the file does not load correctly in the app.
Tested with 3.10.4

I guess that is a workflow problem in the android code @TomTasche

@marcel263
Copy link
Author

I think this should work @marcel263 - does this only show up for a single file or all of the encrypted XLSX? In case this only happens for a specific file would you be able to share it with us?

Dear, the attached file was created with Calc 7.6.6.3 on Linux x86_64. It was password-protected with "password". It reproduces the app's issue of not opening.
Untitled 1.xlsx

@andiwand
Copy link
Member

@TomTasche do you know why this might happen?

@TomTasche
Copy link
Member

I couldn't remember how we handle XLSX so I had to dig it up myself: we upload them to our own server, which uses the LibreOffice CLI to convert the file to PDF and then return that PDF to the client for rendering: https://github.com/opendocument-app/OpenDocument.server/blob/master/index.js

Looks like I simply never thought of password-protected files while implementing the server... We would need to add a server response accordingly and handle that on the client to ask for the password.

@TomTasche TomTasche self-assigned this Jun 16, 2024
@andiwand
Copy link
Member

Alternatively we could use core for encrypted files? Although this requires some logic to handle in which case to use what

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants