Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

energy calculation #25

Open
alLouarn opened this issue Mar 31, 2020 · 0 comments
Open

energy calculation #25

alLouarn opened this issue Mar 31, 2020 · 0 comments

Comments

@alLouarn
Copy link

Hello,
In the 'as_spectral' function, at the line
energy = np.multiply(energy, spectrum), shouldn't it be
energy = np.multiply(1/16*energy, spectrum) ?

Indeed, since the Jonswap spectrum is calculated for Hm0 = 1, we need to update the Johnswap value by multiplying the calculated Jonswap by the true Hm0**2, ie energy/16.

I'm not sure of what I'm saying, it just appears the values obtain for energy = np.multiply(1/16*energy, spectrum) are more realistic than those obtained with the curent implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant