do not attempt to delete the ZFSVolume CR if there is a snapshot holding it.

[pawanpraka1]

ZFSPV allows to delete the volume if snapshot exist for that volume.In this case the node agent keeps on trying to delete the volume and fails to do so since there is a snapshot for the volume, but the PVC and PV get deleted.

Here, we can fail the ZFSVolume deletion, if there is a snapshot on it. PVC will still be deleted and in background the CSI Provisioner will keep on trying to delete the volume and we keep on failing that request until there is a snapshot on it.

Before attempting the delete here :

zfs-localpv/pkg/driver/controller.go

Line 271 in d47ec3b

err = zfs.DeleteVolume(volumeID)

We should check for snapshot and if it exist, fail the deletion.

[ghost]

Also an issue with deleting snapshots that are in use by clones.

[pawanpraka1]

Thanks @chornlgscout for adding the issue related to snapshot deletion when it is in use by clone. Are you already using ZFS-LoclaPV? Could you please let us know your use case and what features you are specifically looking for?

[sinhaashish]

There is a PR to close this issue, but that needs some refactoring, its under review.

[avishnu]

The comment on the fix PR #350 (comment) indicates a possible way to successfully delete the volume by promoting the clone on the oldest snapshot. This functionality will be considered as a future enhancement.

[avishnu]

Tentatively targeting for v4.2