Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] ZFS snapshot is deleted along with the PVC #432

Open
Subetov opened this issue Feb 6, 2023 · 8 comments
Open

[Question] ZFS snapshot is deleted along with the PVC #432

Subetov opened this issue Feb 6, 2023 · 8 comments
Assignees
Milestone

Comments

@Subetov
Copy link

Subetov commented Feb 6, 2023

What steps did you take and what happened:
I created a PCV, populated it with data, created a snapshot, then deleted the PCV, and it turned out that the snapshot also disappears from the host system and it can no longer be restored.
Although the resource "zfssnap" and "volumesnapshot" resources remain in kubernetes.

Is this expected behaviour?

What did you expect to happen:
I assumed that the snapshot will remain and I will be able to restore the data (create a new PVC from the snapshot)

Environment:

  • ZFS-LocalPV version: 2.1.0
  • Kubernetes version: v1.24.8
@sinhaashish
Copy link
Member

hi @Subetov
I tried to replicate this isuue, but i was not able to do . Please reply with the steps you followed.
Steps : followed

  1. Stopped the fio
  2. Deleted the pvc
  3. Checked the snapshot , it exist
    Screenshot 2023-09-13 at 10 50 55 AM

@Subetov
Copy link
Author

Subetov commented Sep 13, 2023

Hello @sinhaashish
Oh it was a long time ago, but as I remember snapshot was deleted from the host machine (not zfssnap k8s custom resource )
Checked with zfs list -t snapshot on the host machine.

@sinhaashish
Copy link
Member

Hi @Subetov ,
Yes its the expected behaviour.
Upon deletion of PVC , the PV as well as snapshot gets deleted.
There is a PR which prevent volume deletion if snapshot exists . #350 . Its under review as of now.

@Subetov
Copy link
Author

Subetov commented Sep 13, 2023

Thank you, @sinhaashish for the reply.
I saw that ticket, it's been waiting its turn for two years now. =)

@sinhaashish
Copy link
Member

@Subetov , yes there were some other concerns and high priority jobs for us, but now we are actively looking on this repo.
Dont worry , your concern will be taken care.

@Subetov
Copy link
Author

Subetov commented Sep 13, 2023

@sinhaashish, thank you a lot.

@avishnu
Copy link
Member

avishnu commented Oct 3, 2024

Re-opening this for further investigation and fixing if needed.

@avishnu avishnu reopened this Oct 3, 2024
@avishnu avishnu modified the milestones: v4.3, v4.2 Oct 3, 2024
@avishnu
Copy link
Member

avishnu commented Oct 3, 2024

This seems important, prioritizing for v4.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants