Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning message to Discard Changes button #1405

Open
jmakowski1123 opened this issue Oct 18, 2024 · 5 comments
Open

Add warning message to Discard Changes button #1405

jmakowski1123 opened this issue Oct 18, 2024 · 5 comments

Comments

@jmakowski1123
Copy link

jmakowski1123 commented Oct 18, 2024

When users click on "Discard Changes", display a warning and confirmation dialog before actually discarding changes.

The message should read:

Are you sure you want to discard all unpublished changes in this library? This will include changes made by other users.

Screenshot 2024-10-22 at 6 34 01 PM

@jmakowski1123
Copy link
Author

@bradenmacdonald Is this something that can be added post code-cut?

@bradenmacdonald
Copy link
Contributor

bradenmacdonald commented Oct 18, 2024

Oooh yeah we should put a confirmation on that. I suggest a warning confirm dialog would be better, like we're doing for "delete component":

image

(But it would say "Are you sure you want to discard all unpublished changes in this library? This will include changes made by other users")

@jmakowski1123
Copy link
Author

Yes, agree and this looks good

@bradenmacdonald
Copy link
Contributor

bradenmacdonald commented Oct 23, 2024

@jmakowski1123 @sdaitzman @lizc577 @marcotuts This is ready for acceptance testing on the sandbox.

@lizc577
Copy link

lizc577 commented Oct 23, 2024

This looks good, I am noticing a fraction of a second delay in the message where it generates the title of the component in the delete message. not a show stopper, but thought it was worth noting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready for AC testing
Development

No branches or pull requests

3 participants