Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce OEP-1 clause that all OEPs should be merged even if rejected/withdrawn #428

Open
Tracked by #128
kdmccormick opened this issue Feb 11, 2022 · 5 comments
Open
Tracked by #128

Enforce OEP-1 clause that all OEPs should be merged even if rejected/withdrawn #428

kdmccormick opened this issue Feb 11, 2022 · 5 comments
Assignees
@sarina
Labels
in review

Comments

@kdmccormick
Copy link
Member

kdmccormick commented Feb 11, 2022 •
edited
Loading

@kdmccormick kdmccormick mentioned this issue Feb 11, 2022
Open
10 tasks
@kdmccormick kdmccormick self-assigned this Feb 11, 2022
@kdmccormick kdmccormick mentioned this issue Dec 20, 2022
Closed
@kdmccormick kdmccormick transferred this issue from openedx/axim-engineering Dec 20, 2022
@kdmccormick kdmccormick removed their assignment Dec 20, 2022
@kdmccormick
Copy link
Member Author

Unassigning myself as I have no current plans to do this.

@sarina
Copy link
Contributor

sarina commented May 17, 2024

@kdmccormick for this one, would you suggest I go through all unmerged PRs and reopen and merge them with an appropriate status?

@sarina sarina self-assigned this May 17, 2024
@kdmccormick
Copy link
Member Author

That's what OEP-1 says to do. Personally, I think it's a little silly. If I wanted to know the rejected OEPs, I could just look at closed PRs.

@sarina sarina added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label May 17, 2024
@sarina
Copy link
Contributor

sarina commented May 17, 2024

I think I do see the sense in it, because most people don't go through closed PRs. I think I'll take this on

@sarina sarina added help wanted Ready to be picked up by anyone in the community and removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels May 17, 2024
sarina added a commit that referenced this issue Jul 4, 2024
@sarina
docs: Update OEP-1: Rejected or withdrawn PRs may be left unmerged
0e32297 
Reflect reality that rejected or withdrawn proposals are frequently left
unmerged even though OEP-1 had previously called for it.

Addresses #428
@sarina sarina mentioned this issue Jul 4, 2024
Merged
@sarina
Copy link
Contributor

sarina commented Jul 4, 2024

Ultimately I agree with you, @kdmccormick . I don't think it's worth the time to merge PRs that never materialized. I updated OEP-1 accordingly and discussion can continue on #601

@sarina sarina added in review and removed help wanted Ready to be picked up by anyone in the community labels Jul 4, 2024
sarina added a commit that referenced this issue Jul 9, 2024
@sarina
docs: Update OEP-1: Rejected or withdrawn PRs may be left unmerged
ce04d3a 
Reflect reality that rejected or withdrawn proposals are frequently left
unmerged even though OEP-1 had previously called for it.

Addresses #428
sarina added a commit that referenced this issue Jul 22, 2024
@sarina
docs: Update OEP-1: Rejected or withdrawn PRs may be left unmerged
8c76951 
Reflect reality that rejected or withdrawn proposals are frequently left
unmerged even though OEP-1 had previously called for it.

Addresses #428
sarina added a commit that referenced this issue Jul 24, 2024
@sarina
docs: Update OEP-1: Rejected or withdrawn PRs may be left unmerged
4c81b5c 
Reflect reality that rejected or withdrawn proposals are frequently left
unmerged even though OEP-1 had previously called for it.

Addresses #428
davidjoy pushed a commit to davidjoy/open-edx-proposals that referenced this issue Aug 28, 2024
@sarina @davidjoy
docs: Update OEP-1: Rejected or withdrawn PRs may be left unmerged
171c796 
Reflect reality that rejected or withdrawn proposals are frequently left
unmerged even though OEP-1 had previously called for it.

Addresses openedx#428
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sarina sarina

Labels
in review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sarina @kdmccormick