Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLRU Issue] In case of CMO_PREFETCH plru behaves differently in case if HIT or MISS #18

Open
khandelwaltanuj opened this issue Apr 18, 2024 · 4 comments · Fixed by #33
Assignees
Labels
bug Something isn't working

Comments

@khandelwaltanuj
Copy link

Hello,

Following observation are made in the case of CMO_PREFETCH (prefetch_updt_plru == 1)

  1. in case of hit PLRU is not updated
  2. in case of miss PLRU is updated once the read memory response is received.

This seems inconsistant. Can you please take a look at it ?

Thanks and regards
Tanuj Khandelwal

@khandelwaltanuj
Copy link
Author

Hi @cfuguet

Do you have any update on this ?

Thanks and Regards
Tanuj Khandelwal

@cfuguet
Copy link
Contributor

cfuguet commented Oct 18, 2024

Hello @khandelwaltanuj,

I forgot about this one. Yes, this should be fixed. I will do it.

The fix will do the following:

  • In case of PREFETCH hit, the PLRU is updated if prefetch_updt_plru == 1
  • In case of PREFETCH miss, the PLRU is updated at refill time if prefetch_updt_plru == 1

Thanks for spotting this out

@cfuguet cfuguet self-assigned this Oct 18, 2024
@cfuguet
Copy link
Contributor

cfuguet commented Oct 18, 2024

Fixed in commit ab4b7ea

Let me know if this fixes the issue you are seeing in the UVM testbench. If it does, please you can close this issue.

Cheers !

@cfuguet cfuguet added the bug Something isn't working label Oct 18, 2024
@cfuguet cfuguet linked a pull request Oct 18, 2024 that will close this issue
@khandelwaltanuj
Copy link
Author

Hi @cfuguet

This fix is working in my regression. I am keeping it open, as I am not able to merge the new version to TB yet.

Regards
Tanuj Khandelwal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants