Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SH for Jersey #398

Open
Lee-Carre opened this issue Jun 8, 2021 · 2 comments
Open

SH for Jersey #398

Lee-Carre opened this issue Jun 8, 2021 · 2 comments
Assignees

Comments

@Lee-Carre
Copy link

An error occurred during evaluation of the value "SH". Please submit a pull request: https://github.com/opening-hours/opening_hours.js. There are no holidays (SH) defined for country je.

Perma-link.

School holidays for Jersey can be extracted from School Term Dates and Holidays.

@ypid
Copy link
Member

ypid commented Jun 8, 2021

I updated my policy how to handle such issues https://github.com/opening-hours/opening_hours.js#holidays

Short, thank you but I cannot take the time to add the holidays myself. But you are welcome to work on it and I will take the time to integrate/merge your work.

@Lee-Carre
Copy link
Author

Please re-open (apparently I'm not allowed to, myself) since I'm currently working on this for a PR.

@ypid ypid reopened this Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants