Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: IMPPY3D: Image Processing in Python for 3D Image Stacks #7362

Closed
editorialbot opened this issue Oct 17, 2024 · 41 comments
Closed
Assignees
Labels
Cython pre-review Python TeX Track: 7 (CSISM) Computer science, Information Science, and Mathematics

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Oct 17, 2024

Submitting author: @NM0ser (Newell Moser)
Repository: https://github.com/usnistgov/imppy3d
Branch with paper.md (empty if default branch):
Version: v1.1.0
Editor: @danielskatz
Reviewers: @sitic, @gknapp1
Managing EiC: Daniel S. Katz

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/8971a1c83405db498ceda13cb4a39ee1"><img src="https://joss.theoj.org/papers/8971a1c83405db498ceda13cb4a39ee1/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/8971a1c83405db498ceda13cb4a39ee1/status.svg)](https://joss.theoj.org/papers/8971a1c83405db498ceda13cb4a39ee1)

Author instructions

Thanks for submitting your paper to JOSS @NM0ser. Currently, there isn't a JOSS editor assigned to your paper.

@NM0ser if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 7 (CSISM) Computer science, Information Science, and Mathematics labels Oct 17, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.13 s (332.6 files/s, 249114.4 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
C                                1            695           3287          12337
Python                          28           3072           5447           5421
YAML                            10              0              0           1049
Cython                           1             76             79            276
TeX                              1             23              0            252
Markdown                         2             47              0            144
-------------------------------------------------------------------------------
SUM:                            43           3913           8813          19479
-------------------------------------------------------------------------------

Commit count by author:

    23	NM0ser
     8	Moser
     1	Karen Price

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 1255

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

🟡 License found: Other (Check here for OSI approval)

@editorialbot
Copy link
Collaborator Author

@danielskatz
Copy link

👋 @NM0ser - thanks for your submission.
Note that your paper does not compile. Please follow the example paper and note that you can click on the error above to find out more about it. Please feel free to make changes to your .md file, then use the command @editorialbot generate pdf to make a new PDF. editorialbot commands need to be the first entry in a new comment.

@NM0ser
Copy link

NM0ser commented Oct 17, 2024

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

@NM0ser
Copy link

NM0ser commented Oct 17, 2024

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

MyPTV: A Python Package for 3D Particle Tracking
Submitting author: @ronshnapp
Handling editor: @jgostick (Active)
Reviewers: @leahmendelson, @jgostick
Similarity score: 0.7310

bmiptools: BioMaterials Image Processing Tools
Submitting author: @lcmpikg
Handling editor: @AoifeHughes (Retired)
Reviewers: @taw10, @mooniean
Similarity score: 0.7261

SCIMAP: A Python Toolkit for Integrated Spatial Analysis of Multiplexed Imaging Data
Submitting author: @ajitjohnson
Handling editor: @csoneson (Active)
Reviewers: @jluethi, @kevinyamauchi, @NMontanaBrown
Similarity score: 0.7145

PiSCAT: A Python Package for Interferometric Scattering Microscopy
Submitting author: @po60nani
Handling editor: @emdupre (Active)
Reviewers: @ziatdinovmax, @aquilesC
Similarity score: 0.7078

Efficient Polyhedral Gravity Modeling in Modern C++ and Python
Submitting author: @schuhmaj
Handling editor: @dfm (Active)
Reviewers: @mikegrudic, @santisoler
Similarity score: 0.7026

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@NM0ser
Copy link

NM0ser commented Oct 17, 2024

@danielskatz
Sorry about that! I clicked everything saying I had checked that it compiled -- and it did in the local Docker image -- but I guess there was some formatting issues in the metadata fields at the beginning. Looks like it worked this time.

@danielskatz
Copy link

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.7717/peerj.453 is OK
- 10.21105/joss.01450 is OK
- 10.1107/S1600577514013939 is OK
- 10.1038/nmeth.2019 is OK
- 10.1186/2193-9772-3-5 is OK
- 10.21105/joss.02286 is OK
- 10.1016/j.softx.2021.100775 is OK
- 10.1007/s40799-024-00715-y is OK
- 10.1007/s40192-023-00333-3 is OK
- 10.1016/j.matdes.2023.112381 is OK
- 10.1038/s41597-023-02092-4 is OK
- 10.1016/j.ijfatigue.2022.106810 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: IMPPY3D
- No DOI given, and none found for title: Dragonfly 3D World
- No DOI given, and none found for title: Avizo
- No DOI given, and none found for title: The OpenCV Library
- No DOI given, and none found for title: The ParaView guide: updated for ParaView version 4...
- No DOI given, and none found for title: Tomviz
- No DOI given, and none found for title: 3D Slicer
- No DOI given, and none found for title: Miniforge

❌ MISSING DOIs

- None

❌ INVALID DOIs

- https://doi.org/10.1016/j.icarus.2024.116166 is INVALID because of 'https://doi.org/' prefix

@danielskatz
Copy link

@NM0ser - please also fix the one DOI mentioned above with the extra prefix in the bibtex doi field.

@NM0ser
Copy link

NM0ser commented Oct 17, 2024

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.7717/peerj.453 is OK
- 10.21105/joss.01450 is OK
- 10.1107/S1600577514013939 is OK
- 10.1038/nmeth.2019 is OK
- 10.1186/2193-9772-3-5 is OK
- 10.21105/joss.02286 is OK
- 10.1016/j.softx.2021.100775 is OK
- 10.1007/s40799-024-00715-y is OK
- 10.1007/s40192-023-00333-3 is OK
- 10.1016/j.matdes.2023.112381 is OK
- 10.1038/s41597-023-02092-4 is OK
- 10.1016/j.ijfatigue.2022.106810 is OK
- 10.1016/j.icarus.2024.116166 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: IMPPY3D
- No DOI given, and none found for title: Dragonfly 3D World
- No DOI given, and none found for title: Avizo
- No DOI given, and none found for title: The OpenCV Library
- No DOI given, and none found for title: The ParaView guide: updated for ParaView version 4...
- No DOI given, and none found for title: Tomviz
- No DOI given, and none found for title: 3D Slicer
- No DOI given, and none found for title: Miniforge

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

@NM0ser
Copy link

NM0ser commented Oct 17, 2024

Thanks, fixed.

@danielskatz
Copy link

@editorialbot assign me as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @danielskatz is now the editor

@danielskatz
Copy link

👋 @NM0ser - Please suggest ~5 potential reviewers. You can search the list of people that have already agreed to review and may be suitable for this submission. Or people who aren't in the JOSS system would also be ok. If you know their GitHub usernames, then please mention them here in this thread (without tagging them with an @).

@danielskatz
Copy link

👋 @matthewturk - I wonder if you have anyone in your group who might be able and willing to review this JOSS submission?

@NM0ser
Copy link

NM0ser commented Oct 17, 2024

Great, thanks! I'll work on this list of potential reviewers.

@NM0ser
Copy link

NM0ser commented Oct 22, 2024

Here is a list of potential reviewers from the list of people:
jrkerns
sitic
ianhi
jonbmartin
ThomasA

And two more outside of that list:
dwatr001
gknapp1

@danielskatz
Copy link

👋 @dwatr001 & @gknapp1, would one or both of you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

@danielskatz
Copy link

👋 @jrkerns, @sitic, @ianhi - would one or more of you be willing to review this JOSS submission?

@sitic
Copy link

sitic commented Oct 22, 2024

I can review this submission

@danielskatz
Copy link

Thanks @sitic - I'll add you, and once we get one or two more reviewers, we will start the review itself

@danielskatz
Copy link

@editorialbot add @sitic as reviewer

@editorialbot
Copy link
Collaborator Author

@sitic added to the reviewers list!

@gknapp1
Copy link

gknapp1 commented Oct 22, 2024

@danielskatz, thanks for the invitation. I can review this submission.

@danielskatz
Copy link

Thanks @gknapp1 - I'll add you, and see if I can get one more reviewer, then I'll start the review

@danielskatz
Copy link

@editorialbot add @gknapp1 as reviewer

@editorialbot
Copy link
Collaborator Author

@gknapp1 added to the reviewers list!

@ianhi
Copy link

ianhi commented Oct 23, 2024

Hi @danielskatz

I could potentially review this - but only on the caveat that I may have very slow response times. I'm both attempting to finish grad school in the next few months as well as have a wedding in December. So if someone else is available please go with them, but I'm happy to serve as a (potentially slow to review) backup

@danielskatz
Copy link

Thanks @ianhi - I hope we can find another person with less external pressures.

@danielskatz
Copy link

👋 @jonbmartin & @ThomasA - would one of you be willing to review this JOSS submission?

@jonbmartin
Copy link

jonbmartin commented Oct 23, 2024 via email

@danielskatz
Copy link

👋 @sitic and @gknapp1 - let's go ahead with the two of you. I'll start the review and see you over in the new issue

@danielskatz
Copy link

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #7405.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cython pre-review Python TeX Track: 7 (CSISM) Computer science, Information Science, and Mathematics
Projects
None yet
Development

No branches or pull requests

7 participants