-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: SlicerSPECTRecon: A 3D Slicer Extension for SPECT Image Reconstruction #7399
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Software report:
Commit count by author:
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
License info: ✅ License found: |
👋🏼 @ObedDzik, @zapaishchykova, @cnmy-ro this is the review thread for the paper. All of our communications will happen here from now on. As a reviewer, the first step is to create a checklist for your review by entering
as the top of a new comment in this thread. There are additional guidelines in the message at the start of this issue. Please feel free to ping me (@mstimberg) if you have any questions/concerns. |
@mstimberg we'll be merging the |
There is no general issue with this, but please make it clear for the reviewers how to best test/install the software. |
Review checklist for @zapaishchykovaConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Hello!
FYI using the dev brunch Minor suggestion is to make errors not "silent" in the python log only, but also guide users that it won't work without photopeak selected |
Thanks for the good suggestion @zapaishchykova : ) . What are your thoughts on us providing some sort of youtube tutorial demonstrating how to use the software, and being explicit about the instructions/required fields to fill in? |
@lukepolson - this is a great suggestion, it could be also as simple as instructions in the Readme |
Sounds good, we also have a user manual file as well, but maybe it is difficult to find, so we can make it more explicit in the README. |
Submitting author: @ObedDzik (Obed Dzikunu)
Repository: https://github.com/PyTomography/slicer_spect_recon.git
Branch with paper.md (empty if default branch): j_paper
Version: v1.0.0
Editor: @mstimberg
Reviewers: @zapaishchykova, @cnmy-ro
Archive: Pending
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@zapaishchykova & @cnmy-ro, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @mstimberg know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @zapaishchykova
The text was updated successfully, but these errors were encountered: