Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future Annotation Improvements #633

Open
3 tasks
PGijsbers opened this issue Aug 29, 2024 · 1 comment
Open
3 tasks

Future Annotation Improvements #633

PGijsbers opened this issue Aug 29, 2024 · 1 comment
Labels
quality Something needs to be tested, keep the app functional

Comments

@PGijsbers
Copy link
Collaborator

PGijsbers commented Aug 29, 2024

Some notes for later as I go along with writing type hints, on things that I can't tackle because they require a newer Python version or a larger refactoring than I want to do right now (I want some test coverage first).

  • The file formats that are stored by string should be StrEnum when we move to 3.11+
  • Introduce namedtuples for "complex" return types, like the loaded benchmarks
  • Enums for options of the Encoder of the DataUtils (or see if we can somehow remove that altogether. It's there now so we don't have a dependency on sklearn in the framework virtual environment)
@PGijsbers PGijsbers added the quality Something needs to be tested, keep the app functional label Aug 29, 2024
@PGijsbers
Copy link
Collaborator Author

Other remarks, not typing related:

  • not self.delegate should be a none check for encoder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality Something needs to be tested, keep the app functional
Projects
None yet
Development

No branches or pull requests

1 participant