Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fields missing from patent call #17

Open
madgpap opened this issue Sep 23, 2015 · 5 comments
Open

Fields missing from patent call #17

madgpap opened this issue Sep 23, 2015 · 5 comments
Assignees

Comments

@madgpap
Copy link

madgpap commented Sep 23, 2015

e.g.
http://ops2.few.vu.nl/1.5/patent?app_id=15a18100&app_key=528a8272f1cd961d215f318a0315dd3d&uri=http%3A%2F%2Frdf.ebi.ac.uk%2Fresource%2Fsurechembl%2Fpatent%2FUS-8877786-B2&_format=xml

occursInPatentTitle and occursInPatentAbstract are missing

@ianwdunlop
Copy link
Member

According to the docs https://dev.openphacts.org/docs/develop these are optional fields (highlighted in yellow in the docs). Did you expect them to be there for this item?

@madgpap
Copy link
Author

madgpap commented Sep 23, 2015

Hi Ian
Thanks for the quick reply. According to the docs, there are a lot of optional fields which are still included in the response, such as occursInPatentDescription and occursInPatentClaims.
For completeness, I would expect all the "occursIn..." attributes to be there for all the mentions in a patent.

@ianwdunlop
Copy link
Member

Do you mean that even 'optional' fields that have no data should be in the response but be empty.
eg.
or that you think there should actually be data for those fields and that the API is missing something. Maybe @agaulton, @danidi or @antonisloizou would be able to comment better than me.

@madgpap
Copy link
Author

madgpap commented Sep 23, 2015

It is the former.
All the "occursIn..." boolean attributes should be present for each mention attribute of the API patent call.
I hope it is clear now.

@danidi
Copy link

danidi commented Sep 23, 2015

I wrote feedback on the call some time ago per email, it included the following:

  • It would be great to have an example patent where actually all of the places are at least mentioned once, to see how it would look like in the output. Or you could show the missing occursInPatent by also displaying them with the value ‘false’.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants