Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update git-changelist-maven-extension if needed #16

Open
basil opened this issue Aug 18, 2023 · 1 comment
Open

Update git-changelist-maven-extension if needed #16

basil opened this issue Aug 18, 2023 · 1 comment
Labels
recipe Requests for new automated code changes

Comments

@basil
Copy link
Contributor

basil commented Aug 18, 2023

In addition to updating the plugin parent POM to the latest version, the version of git-changelist-maven-extension in .mvn/extensions.xml should be updated to the latest version if necessary. Version 1.6 is the last version that works on Java 8; 1.7 and later require Java 11+.

@timtebeek timtebeek added the recipe Requests for new automated code changes label Aug 18, 2023
@timtebeek
Copy link
Contributor

It looks like the closest we have to this might be the Add Gradle Enterprise Maven extension recipe at https://github.com/openrewrite/rewrite/blob/main/rewrite-maven/src/main/java/org/openrewrite/maven/AddGradleEnterpriseMavenExtension.java

While that adds a plugin, that might not be needed here, making this implementation easier by comparison. It does show we're already able to parse and manipulate maven extensions, so there should not be any hurdles to clear for this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
recipe Requests for new automated code changes
Projects
Status: Recipes Wanted
Development

No branches or pull requests

2 participants