Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

org.openrewrite.jenkins.BomLookup is too simplistic #40

Open
basil opened this issue Aug 22, 2023 · 1 comment
Open

org.openrewrite.jenkins.BomLookup is too simplistic #40

basil opened this issue Aug 22, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@basil
Copy link
Contributor

basil commented Aug 22, 2023

org.openrewrite.jenkins.BomLookup reads jenkins-plugins-bom-lookup.txt and checks to see if the plugin is present in this file. In reality, this list is constantly changing as plugins are added/removed to the plugin BOM. For example, newer releases of the plugin BOM have more plugins in the managed set than older releases. For a foolproof strategy, fetch the plugin BOM in use in the <dependencyManagement> section and determine if it is managing the given plugin.

@sghill
Copy link
Collaborator

sghill commented Aug 23, 2023

Agree - an earlier implementation did do this, but it felt a bit complex for a first release. Some of the plugins I was attempting to modernize had the added complexity of being from before the core bom was resolvable. Now that we have modernizing for Java 8 separated out, it's worth revisiting.

There are some nice APIs from within a recipe to get a managed dependency after resolution is performed.

@joanvr joanvr added the enhancement New feature or request label Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

3 participants