-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EasyMock to Mockito #454
Comments
Hi @jpraet ! Thanks for the suggestion; looking at the gist link this appears relatively straightforward: sed -i 's/org.easymock.EasyMock.createNiceMock/org.mockito.Mockito.mock/g' $item
sed -i 's/org.easymock.EasyMock.createMock/org.mockito.Mockito.mock/g' $item
sed -i 's/org.easymock.EasyMock.expect/org.mockito.Mockito.when/g' $item
sed -i 's/org.easymock.EasyMock/org.mockito.Mockito/g' $item
sed -i 's/EasyMock/Mockito/g' $item
sed -i 's/createNiceMock/mock/g' $item
sed -i 's/createMock/mock/g' $item
sed -i 's/expect(/when(/g' $item
sed -i 's/andReturn/thenReturn/g' $item
sed -i 's/\.anyTimes()//g' $item
sed -i '/replay[^A-Za-z0-9]/d' $item At first glance most, if not all of these can be converted to use recipes we already have which you can compose in our recipe builder at https://app.moderne.io/recipes/builder type: specs.openrewrite.org/v1beta/recipe
name: java.testing.easymock.EasyMockToMockito
displayName: Migrate from EasyMock to Mockito
description: This recipe will apply changes commonly needed when migrating from EasyMock to Mockito.
recipeList:
- org.openrewrite.java.ChangeMethodTargetToStatic:
methodPattern: org.easymock.EasyMock createNiceMock(..)
fullyQualifiedTargetTypeName: org.mockito.Mockito
- org.openrewrite.java.ChangeMethodName:
methodPattern: org.mockito.Mockito createNiceMock(..)
newMethodName: mock
... We already have a very similar recipe for JMockit: https://github.com/openrewrite/rewrite-testing-frameworks/blob/main/src/main/resources/META-INF/rewrite/jmockit.yml Would you be willing to create a first draft of these migration recipes to get this started? |
There are some more complicated behaviours I have found in my codebase that will require some more complicated recipes e.g:
But for a first draft, it does quite well :) |
|
Thanks a lot for sharing @dblackhall-tyro ! Great to see this kicked off. Would you be willing to contribute these on a draft PR? That way you get credited as the recipe author in our docs. We can collaborate and iterate from there. |
Certainly! I've found a few more small cases over the last few days so I'll wrap them all up and create a PR |
What problem are you trying to solve?
Migrate from EasyMock to Mockito.
Resources:
The text was updated successfully, but these errors were encountered: