RemoveTestPrefix does not check if a similarly named static import exists

[blipper]

What version of OpenRewrite are you using?

Latest

How are you running OpenRewrite?

gradle

What is the smallest, simplest way to reproduce the problem?

import static Bar.foo; 
@Test
class A {
    void testFoo() {
    }
}

What did you expect to see?

@Test
class A {
    void testFoo() {
    }
}

What did you see instead?

@Test
class A {
    void foo() {
    }
}

What is the full stack trace of any errors you encountered?

Compilation will fail

Are you interested in contributing a fix to OpenRewrite?

Yes

[timtebeek]

Thanks for the clear example and offer to help @blipper! Must say it's appreciated how diligently you're reporting issues you come across. Really helps fix any blind spots.

Your examples would fit right in as a unit test, similar to this earlier one:

rewrite-testing-frameworks/src/test/java/org/openrewrite/java/testing/cleanup/RemoveTestPrefixTest.java

Lines 328 to 347 in 30f35fe

	@Test
	@Issue("https://github.com/openrewrite/rewrite-testing-frameworks/issues/258")
	void removeTestPrefixWithClashingMethod() {
	rewriteRun(
	//language=java
	java(
	"""
	import org.junit.jupiter.api.Test;
	import static java.util.List.of;
	class FooTest {
	@Test
	void testOf() {
	of();
	}
	}
	"""
	)
	);
	}

Once there's a test we will likely want to add a similar exemption as seen here:

rewrite-testing-frameworks/src/main/java/org/openrewrite/java/testing/cleanup/RemoveTestPrefix.java

Lines 125 to 138 in 30f35fe

	// Skip when calling a similarly named method
	AtomicBoolean skip = new AtomicBoolean(false);
	new JavaIsoVisitor<AtomicBoolean>() {
	@Override
	public J.MethodInvocation visitMethodInvocation(J.MethodInvocation method, AtomicBoolean atomicBoolean) {
	if (method.getName().getSimpleName().equals(newMethodName)) {
	skip.set(true);
	}
	return super.visitMethodInvocation(method, atomicBoolean);
	}
	}.visitMethodDeclaration(m, skip);
	if (skip.get()) {
	return m;
	}

Your exact example might already work if the name of the static imported method matches the renamed test; but with a few small adjustments I'm sure we can find a way to fail and then fix the issue.