Issue discovered on src/test/resources/dataflow-functional-tests/ArchiveAnalyzer.java with Use Files#createTempDirectory``

[kmccarp]

Problem

The recipe org.openrewrite.java.security.UseFilesCreateTempDirectory made a change that deletes a bunch of code that may or may not be needed.

Expected behavior

I expected the recipe to only make the required set of changes. The result I got changes the underlying behavior.

Example diff

From: src/test/resources/dataflow-functional-tests/ArchiveAnalyzer.java

 
import javax.annotation.concurrent.ThreadSafe;
import java.io.*;
+import java.nio.file.Files;
import java.nio.file.Path;
import java.util.*;
import java.util.concurrent.atomic.AtomicInteger;

public void prepareFileTypeAnalyzer(Engine engine) throws InitializationException {
try {
  final File baseDir = getSettings().getTempDirectory();
-            tempFileLocation = File.createTempFile("check", "tmp", baseDir);
-            if (!tempFileLocation.delete()) {
-                setEnabled(false);
-                final String msg = String.format("Unable to delete temporary file '%s'.", tempFileLocation.getAbsolutePath());
-                throw new InitializationException(msg);
-            }
-            if (!tempFileLocation.mkdirs()) {
-                setEnabled(false);
-                final String msg = String.format("Unable to create directory '%s'.", tempFileLocation.getAbsolutePath());
-                throw new InitializationException(msg);
-            }
+            tempFileLocation = Files.createTempDirectory(baseDir.toPath(), "check" + "tmp").toFile();
} catch (IOException ex) {
  setEnabled(false);
  throw new InitializationException("Unable to create a temporary file", ex);

Recipes in example diff:

• org.openrewrite.java.security.UseFilesCreateTempDirectory

References:

• View original result
• Recipe ID: org.openrewrite.java.security.UseFilesCreateTempDirectory
• Recipe Name: Use Files#createTempDirectory``
• Repository: openrewrite/rewrite-analysis/main
• Created at Thu Aug 22 2024 09:49:22 GMT-0300 (Horário Padrão da Argentina)